New issue
Advanced search Search tips
Starred by 49 users
Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 803833
issue 808732



Sign in to add a comment
Implement AbortController, AbortSignal, abortable fetch
Project Member Reported by jakearchibald@chromium.org, Jul 31 2017 Back to list
https://dom.spec.whatwg.org/#aborting-ongoing-activities

Fetch abort tests are at https://github.com/w3c/web-platform-tests/pull/6484.

Fetch abort spec is in progress https://github.com/whatwg/fetch/pull/523.

Mozilla intends to start implementing next month, using the tests rather than the spec.
 
Cc: ricea@chromium.org
Labels: -Pri-3 Pri-2
Status: Available
Great that we're closer to fetch() + cancellation!

+ricea@ tentatively
Cc: engedy@chromium.org
Cc: kpaulhamus@chromium.org
Owner: ricea@chromium.org
Status: Assigned
Blocking: 803833
Blocking: 161072
Blocking: 808732
Project Member Comment 10 by bugdroid1@chromium.org, Feb 5
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ea192285757861d168b6e508bb34bc054194a22

commit 3ea192285757861d168b6e508bb34bc054194a22
Author: Adam Rice <ricea@chromium.org>
Date: Mon Feb 05 09:08:10 2018

Implement AbortController and AbortSignal

Also adjust layout tests expectations to match the new behaviour. One
fetch() wpt test that previously failed due to AbortController being
undefined now times out because the "signal" properties in fetch options
doesn't do anything yet. This will be fixed once it is implemented.

Spec: https://dom.spec.whatwg.org/#aborting-ongoing-activities
Design doc: https://docs.google.com/document/d/1OuoCG2uiijbAwbCw9jaS7tHEO0LBO_4gMNio1ox0qlY/edit
Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/9vNZh4fhV2U/ZVxD2iQACgAJ

BUG=750599

Change-Id: I0e504bbf7f8552d602913ee2069bbf90f95deaff
Reviewed-on: https://chromium-review.googlesource.com/896669
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534352}
[modify] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/406010c4b4e27073d52f2d7af881a302d1beae99/third_party/WebKit/LayoutTests/external/wpt/dom/abort/event.any-expected.txt
[modify] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/LayoutTests/external/wpt/dom/abort/event.any.js
[delete] https://crrev.com/406010c4b4e27073d52f2d7af881a302d1beae99/third_party/WebKit/LayoutTests/external/wpt/dom/abort/event.any.worker-expected.txt
[delete] https://crrev.com/406010c4b4e27073d52f2d7af881a302d1beae99/third_party/WebKit/LayoutTests/external/wpt/dom/interface-objects-expected.txt
[delete] https://crrev.com/406010c4b4e27073d52f2d7af881a302d1beae99/third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt
[modify] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/LayoutTests/external/wpt/dom/interfaces.html
[modify] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/LayoutTests/external/wpt/fetch/api/abort/cache.https-expected.txt
[modify] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/LayoutTests/external/wpt/fetch/api/abort/serviceworker-intercepted.https-expected.txt
[modify] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[delete] https://crrev.com/406010c4b4e27073d52f2d7af881a302d1beae99/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/Source/core/core_idl_files.gni
[add] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/Source/core/dom/AbortController.cpp
[add] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/Source/core/dom/AbortController.h
[add] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/Source/core/dom/AbortController.idl
[add] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/Source/core/dom/AbortSignal.cpp
[add] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/Source/core/dom/AbortSignal.h
[add] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/Source/core/dom/AbortSignal.idl
[modify] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/Source/core/events/event_target_names.json5
[modify] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/3ea192285757861d168b6e508bb34bc054194a22/tools/metrics/histograms/enums.xml

Blocking: -161072
Sign in to add a comment