New issue
Advanced search Search tips

Issue 750593 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Test crop_rotate_scale field of camera3_stream

Project Member Reported by hywu@chromium.org, Jul 31 2017

Issue description

Originally crop-rotate-scale is designed as a per-frame metadata.
However, on Poppy, enabling crop-rotate-scale would require
reconfiguring the stream, causing a couple of hundreds ms overhead.

Since we don't change crop-rotate-scale state after a stream is created,
setting crop-rotate-scale in configure_stream better fits our purpose
and reduces frame processing time.

The camera3_test should be changed accordingly.
 

Comment 1 by hywu@chromium.org, Aug 3 2017

Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/007449b389b206df24416e5d935a9cf3cb7f19e3

commit 007449b389b206df24416e5d935a9cf3cb7f19e3
Author: Daniel Hung-yu Wu <hywu@chromium.org>
Date: Sat Aug 05 03:17:09 2017

camera3_test: move rotation to stream configuration

Originally crop-rotate-scale is designed as a per-frame metadata.
However, on Poppy, enabling crop-rotate-scale would require
reconfiguring the stream, causing a couple of hundreds ms overhead.

Since we don't change crop-rotate-scale state after a stream is created,
setting crop-rotate-scale in configure_stream better fits our purpose
and reduces frame processing time.

Change camera3_test portrait orientation test accordingly. Also, add
test cases for invalid rotation settings.

BUG= chromium:750593 
TEST='emerge-elm arc-camera3-test'
     'arc_camera3_test
          --gtest_filter=Camera3FrameTest/Camera3PortraitRotationTest.GetFrame/*'

Change-Id: I96a8cbb31c2afa6dac870cbfab7c95bf9f87f0ca
Reviewed-on: https://chromium-review.googlesource.com/597032
Commit-Ready: Hung-yu Wu <hywu@chromium.org>
Tested-by: Hung-yu Wu <hywu@chromium.org>
Reviewed-by: Heng-ruey Hsu <henryhsu@chromium.org>

[modify] https://crrev.com/007449b389b206df24416e5d935a9cf3cb7f19e3/camera3_test/camera3_device_impl.cc
[modify] https://crrev.com/007449b389b206df24416e5d935a9cf3cb7f19e3/camera3_test/camera3_service.cc
[modify] https://crrev.com/007449b389b206df24416e5d935a9cf3cb7f19e3/camera3_test/camera3_device_fixture.h
[modify] https://crrev.com/007449b389b206df24416e5d935a9cf3cb7f19e3/camera3_test/camera3_device_impl.h
[modify] https://crrev.com/007449b389b206df24416e5d935a9cf3cb7f19e3/camera3_test/camera3_stream_test.cc
[modify] https://crrev.com/007449b389b206df24416e5d935a9cf3cb7f19e3/camera3_test/camera3_device_test.cc
[modify] https://crrev.com/007449b389b206df24416e5d935a9cf3cb7f19e3/camera3_test/camera3_frame_test.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/0bf1efdc43f0ac0b1a89d8369202015a4758a9ba

commit 0bf1efdc43f0ac0b1a89d8369202015a4758a9ba
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Wed Aug 09 18:48:04 2017

usb: Fix crop_rotate_scale_degrees when reconfigure streams

When we reconfigure streams, the value is not updated because
RequestHandler already exists. Move the value from constructor to
StreamOn function.

BUG= chromium:750593 
TEST=pass camera3-test

Change-Id: I53aba34fad5b2fafafb12e717464713adcca7c09
Reviewed-on: https://chromium-review.googlesource.com/601687
Commit-Ready: Heng-ruey Hsu <henryhsu@chromium.org>
Tested-by: Heng-ruey Hsu <henryhsu@chromium.org>
Reviewed-by: Hung-yu Wu <hywu@chromium.org>

[modify] https://crrev.com/0bf1efdc43f0ac0b1a89d8369202015a4758a9ba/hal/usb/camera_client.cc
[modify] https://crrev.com/0bf1efdc43f0ac0b1a89d8369202015a4758a9ba/hal/usb/camera_client.h

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/ab33b10064bd005489d6542ad01200040fc33986

commit ab33b10064bd005489d6542ad01200040fc33986
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Wed Aug 16 07:17:52 2017

usb: Remove unused code

1. Remove GetConvertedSize in cached_frame
2. Remove NV21 and YV12 format

BUG= chromium:750593 
TEST=emerge-${BOARD} arc-camera3-hal-usb

Change-Id: I7f21d864e27b9344e908c31a33af3a2d46953fad
Reviewed-on: https://chromium-review.googlesource.com/601688
Commit-Ready: Heng-ruey Hsu <henryhsu@chromium.org>
Tested-by: Heng-ruey Hsu <henryhsu@chromium.org>
Reviewed-by: Hung-yu Wu <hywu@chromium.org>

[modify] https://crrev.com/ab33b10064bd005489d6542ad01200040fc33986/hal/usb/cached_frame.cc
[modify] https://crrev.com/ab33b10064bd005489d6542ad01200040fc33986/hal/usb/image_processor.cc
[modify] https://crrev.com/ab33b10064bd005489d6542ad01200040fc33986/hal/usb/frame_buffer.cc
[modify] https://crrev.com/ab33b10064bd005489d6542ad01200040fc33986/hal/usb/cached_frame.h

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 11 2017

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f0f31ef3c13ba11340f8221a037663f040e8ecf2

commit f0f31ef3c13ba11340f8221a037663f040e8ecf2
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Wed Sep 13 13:17:28 2017

arc-camera3-hal-usb: Add unittest

BUG= chromium:750593 
TEST=FEATURES="test" emerge-${BOARD} arc-camera3-hal-usb
CQ-DEPEND=CL:601689

Change-Id: Ia652370d4eb8061782dfc1c8331a61c9e7e784dd
Reviewed-on: https://chromium-review.googlesource.com/637300
Commit-Ready: Heng-ruey Hsu <henryhsu@chromium.org>
Tested-by: Heng-ruey Hsu <henryhsu@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/f0f31ef3c13ba11340f8221a037663f040e8ecf2/media-libs/arc-camera3-hal-usb/arc-camera3-hal-usb-9999.ebuild

Comment 7 by hywu@chromium.org, Mar 6 2018

Status: Verified (was: Started)

Sign in to add a comment