New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750573 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Blink of Sign-in page is seen on clicking 'TRY AGAIN' button in Sign-in permissions page

Project Member Reported by mmanchala@chromium.org, Jul 31 2017

Issue description

Chrome Version: 62.0.369.0/9794.0.0 dev-channel Paine,Kip and Parrot
OS: Chrome

What steps will reproduce the problem?
(1)Sign in to user -> Go to chrome://md-settings/accounts page -> Enable  'Restrict sign-in to the following users' option so that 'Add person' option is enabled ->Click on 'Add person' -> Enter any email id
(2)Now Click on 'Sign out' option in Uber tray -> In Sign-out screen click on 'Add person' option
(3)Enter another mail id(Ex: mopriya111) -> Now in Sign-in permissions page click on 'TRY AGAIN' button and observe blink of Sign-in page( mopriya111 ID) is seen (Please refer Video and screenshots)

Expected: Blink of Sign-in page should not be seen on clicking 'TRY AGAIN' button
Actual: Instead Blink of Sign-in page is seen

This is Regression issue as same is working fine in 61.0.3157.3/9745.0.0 dev channel Kip

@alemate: Please confirm the issue
 
Actual_BlinkOfSign_inScreen.mp4
6.2 MB View Download
Actual_BlinkOfSign_inScreen-1.jpg
4.4 MB View Download
Actual_BlinkOfSign_inScreen-2.jpg
3.8 MB View Download
Expected.mp4
2.0 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58680ff44a9e66d7ec0154b2bf8de17fddc69913

commit 58680ff44a9e66d7ec0154b2bf8de17fddc69913
Author: Alexander Alekseev <alemate@chromium.org>
Date: Tue Aug 08 06:11:47 2017

ChromeOS: remove flickering on Gaia page reload.

This Cl forces complete Gaia reload on each failed users whitelist check
to make animations correct.

Bug:  750573 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id4e9c7f8ba37c807ef4a975574bd267e812c9d66
Reviewed-on: https://chromium-review.googlesource.com/604944
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492550}
[modify] https://crrev.com/58680ff44a9e66d7ec0154b2bf8de17fddc69913/chrome/browser/resources/chromeos/login/screen_gaia_signin.js

Labels: -M-62 M-61 Merge-Request-61
Status: Fixed (was: Assigned)
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 9 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 9 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb415d318d2f8327787a8765810ecc485dc70b09

commit fb415d318d2f8327787a8765810ecc485dc70b09
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Aug 09 23:16:11 2017

ChromeOS: remove flickering on Gaia page reload.

This Cl forces complete Gaia reload on each failed users whitelist check
to make animations correct.

TBR=alemate@chromium.org

(cherry picked from commit 58680ff44a9e66d7ec0154b2bf8de17fddc69913)

Bug:  750573 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id4e9c7f8ba37c807ef4a975574bd267e812c9d66
Reviewed-on: https://chromium-review.googlesource.com/604944
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492550}
Reviewed-on: https://chromium-review.googlesource.com/609448
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#415}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/fb415d318d2f8327787a8765810ecc485dc70b09/chrome/browser/resources/chromeos/login/screen_gaia_signin.js

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment