Input method restriction on empty login_screen_input_methods proto |
|||||||
Issue descriptionChrome Version: M58+ (?) OS: Chrome OS Summary: Login/Lock screen input method restrictions are active when an empty login_screen_input_methods proto is sent down from the device management server. This causes additional confusion due to bug 748964. Details/Repro with YAPS: What steps will reproduce the problem? (1) Configure YAPS to send down an empty login_screen_input_methods proto in device policy (2) Create a user profile on the Chrome OS device. (3) Focus the user profile pod on the sign-in screen. What is the expected result? You can use all of the default login-screen keyboard layouts What happens instead? Only the user's last-used keyboard layout is usable.
,
Jul 31 2017
The bug is that the input method restriction code runs as soon as the proto is present. It then adds the user's last-used keyboard layout to the list of allowed keyboard layouts, and only then checks if the list is empty. This is a bug and is fixed in CL: https://chromium-review.googlesource.com/c/589436/
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9988a1bb6a0df58747556caa319c4d3019a72418 commit 9988a1bb6a0df58747556caa319c4d3019a72418 Author: Pavol Marko <pmarko@chromium.org> Date: Wed Aug 02 15:28:11 2017 Treat empty login_screen_input_methods policy as no-op If an empty login_screen_input_methods policy is sent from the client, treat it as if the policy was not present. Don't restrict input methods in this case. BUG= 750572 TEST=browser_tests --gtest_filter=LoginScreenPolicyTest.* Change-Id: I83109bb5c7648ac6a7f81da414879745bf905abb Reviewed-on: https://chromium-review.googlesource.com/589436 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#491380} [modify] https://crrev.com/9988a1bb6a0df58747556caa319c4d3019a72418/chrome/browser/chromeos/login/lock_screen_utils.cc [modify] https://crrev.com/9988a1bb6a0df58747556caa319c4d3019a72418/chrome/browser/chromeos/login/login_screen_policy_browsertest.cc
,
Aug 4 2017
This is a small bugfix which I'd like to merge to M-61 because users on google.com were complaining about the bug. Due to the bug, keyboard layouts are sometimes restricted for managed users on the sign-in + lock screen, even though they should not be. (due to wrong handling of empty proto from device management server) The CL in Comment 3 fixes this issue. Thanks!
,
Aug 4 2017
Approving merge to M61 Chrome OS.
,
Aug 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/053f5fd8f35783c7811d4aa419d485f97ba1c9c8 commit 053f5fd8f35783c7811d4aa419d485f97ba1c9c8 Author: Pavol Marko <pmarko@chromium.org> Date: Mon Aug 07 12:59:39 2017 [Merge to M61] Treat empty login_screen_input_methods policy as no-op If an empty login_screen_input_methods policy is sent from the server, treat it as if the policy was not present. Don't restrict input methods in this case. BUG= 750572 TEST=browser_tests --gtest_filter=LoginScreenPolicyTest.* TBR=pmarko@chromium.org (cherry picked from commit 9988a1bb6a0df58747556caa319c4d3019a72418) Change-Id: I83109bb5c7648ac6a7f81da414879745bf905abb Reviewed-on: https://chromium-review.googlesource.com/589436 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#491380} Reviewed-on: https://chromium-review.googlesource.com/603608 Reviewed-by: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#345} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/053f5fd8f35783c7811d4aa419d485f97ba1c9c8/chrome/browser/chromeos/login/lock_screen_utils.cc [modify] https://crrev.com/053f5fd8f35783c7811d4aa419d485f97ba1c9c8/chrome/browser/chromeos/login/login_screen_policy_browsertest.cc
,
Aug 7 2017
,
Aug 7 2017
,
Aug 9 2017
As verified in M61.0.3163.38:9765.21.0 dev edgar, this issue does not reproduce thus confirmed to be fixed. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by pmarko@chromium.org
, Jul 31 2017