Regression: First few pages are not visible in print preview |
||||||
Issue descriptionChrome Version: 62.0.3172.0 OS:Ubuntu 14.04 What steps will reproduce the problem? (1)Launch chrome and open any pdf [eg:http://cb.vu/unixtoolbox.pdf] (2)Hit ctrl+P and observe Expected:All pages should be visible Actual: First few pages are not visible in print preview This is a Regression issue broken in M-62 will update other info soon
,
Jul 31 2017
Able to reproduce this issue on Mac OS 10.12.6 using chrome latest Dev #62.0.3172.0. Since this is a latest regression observed on chrome latest M-62 adding RB-Dev,please feel free to edit if this is not the case. Thanks!
,
Jul 31 2017
Using per revision bisect providing bisect results below Bisect Information: -------------------- You are probably looking for a change made after 490507 (known good), but no later than 490508 (first known bad). Change Log URL: ----------------- https://chromium.googlesource.com/chromium/src/+log/f7091da145833b3c2ee7dd564580b704191f26ea..f64a5de29cd0442fb4f5e7c2896b630c9d5c96a2 Unable to find the actual suspect from the pdfium log, so assigning to the reviewer of the file. dsinclair@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!!
,
Jul 31 2017
,
Jul 31 2017
This was broken in https://pdfium-review.googlesource.com/c/9510/4/fpdfsdk%252Ffpdfppo.cpp#94
,
Jul 31 2017
,
Jul 31 2017
Landed https://pdfium-review.googlesource.com/c/9610/, which reverts the part of the refactoring that introduce this bug.
,
Aug 1 2017
Thanks everyone for quickly identifying the problem and fixing it. Can we add a PDFium test for FPDF_ImportPages() to cover this regression?
,
Aug 1 2017
I became curious why we have many FPDF_ImportPages() tests, but none of them caught this. Then I wrote one more test: https://pdfium-review.googlesource.com/9730
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/465d8c7e2f9ef26784e50e8360f80340fec7ed05 commit 465d8c7e2f9ef26784e50e8360f80340fec7ed05 Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org> Date: Tue Aug 01 06:41:40 2017 Roll src/third_party/pdfium/ f0e9c849a..ab3909796 (5 commits) https://pdfium.googlesource.com/pdfium.git/+log/f0e9c849a3fd..ab3909796cf2 $ git log f0e9c849a..ab3909796 --date=short --no-merges --format='%ad %ae %s' 2017-07-28 drgage Add FORM_ReplaceSelection() and embedder tests. 2017-07-31 hnakashima Initialize CPDF_PathObject members on constructor. 2017-07-31 rharrison Remove null derefence case caught by fuzzers 2017-07-31 rharrison Fix bad change when converting Mid to Left/Right 2017-07-31 rharrison More fixes for coverage_report.py Created with: roll-dep src/third_party/pdfium BUG= 59266 , 750013 , 750568 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I014ffe18675c95a6778bd99e50f317801a45f0fd Reviewed-on: https://chromium-review.googlesource.com/595122 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490888} [modify] https://crrev.com/465d8c7e2f9ef26784e50e8360f80340fec7ed05/DEPS |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by keerthan...@techmahindra.com
, Jul 31 20175.4 MB
5.4 MB View Download