New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750563 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ARC Mojo initialization timing issue.

Project Member Reported by hidehiko@chromium.org, Jul 31 2017

Issue description

Currently, we have two timing issues around Mojo initialization.

1) In Android container,
The implementation of init() needs asynchronous operation.
So, Chrome cannot know when it is actually established.

2) InstanceHolder can have multiple observers.
There is no guarantee about the order of calls.
This means, as Init() is called in one of OnInstanceReady(), there is a possibility that other OnInstanceReady() can be called before Init().

How to solve;

- add another "init" method with callback. It is called when Android side's container gets actually ready. Along with it, deprecate older one.
- move "calling Init()" part from each service implementation to InstanceHolder.
- OnInstanceReady() will be called after new Init()'s callback is called.

This will conflict with other team members' current effort, so suspend till M63.
 
Labels: -M63 M-63
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac2e551b4828308110853c2d143285c8c4a68bb3

commit ac2e551b4828308110853c2d143285c8c4a68bb3
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Nov 21 09:54:46 2017

Extract ConnectionObserver.

InstanceHolder will support full duplex mojo connection
in addition to the current single direction mojo connection,
as a part of Init() race condition fix.
This CL extracts the observer parts, so that it will be
able to be shared by both implementation.

ConnectionObserver::OnChannelReady() will be called
when connection is established. Currently only single
direction mojo connectin is supporeted, so when Instance
is ready, it is called (this is as
InstanceHolder::Observer::OnInstanceReady() is).
When full duplex mojo connection is supported,
it will be called when Instance::Init() is completed.

BUG= 750563 
TEST=Ran bots.

Change-Id: If8e768e6f2485edaa86bd8c374e2a41d1fc74866
Reviewed-on: https://chromium-review.googlesource.com/775238
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518198}
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/auth/arc_auth_service.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/auth/arc_auth_service.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/boot_phase_monitor/arc_boot_phase_monitor_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/boot_phase_monitor/arc_boot_phase_monitor_bridge.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/cast_receiver/arc_cast_receiver_service.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/cast_receiver/arc_cast_receiver_service.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/enterprise/arc_cert_store_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/enterprise/arc_cert_store_bridge.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/enterprise/arc_enterprise_reporting_service.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/enterprise/arc_enterprise_reporting_service.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/fileapi/arc_file_system_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/fileapi/arc_file_system_bridge.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/intent_helper/arc_settings_service.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/kiosk/arc_kiosk_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/kiosk/arc_kiosk_bridge.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/oemcrypto/arc_oemcrypto_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/oemcrypto/arc_oemcrypto_bridge.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/policy/arc_policy_bridge.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/print/arc_print_service.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/print/arc_print_service.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/process/arc_process_service.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/process/arc_process_service.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/tracing/arc_tracing_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/tracing/arc_tracing_bridge.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/tts/arc_tts_service.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/tts/arc_tts_service.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/user_session/arc_user_session_service.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/user_session/arc_user_session_service.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/video/gpu_arc_video_service_host.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/video/gpu_arc_video_service_host.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/sync/test/integration/sync_arc_package_helper.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/task_manager/providers/arc/arc_process_task.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/task_manager/providers/arc/arc_process_task.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/ui/app_list/app_context_menu_unittest.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/BUILD.gn
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/audio/arc_audio_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/audio/arc_audio_bridge.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/clipboard/arc_clipboard_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/clipboard/arc_clipboard_bridge.h
[add] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/connection_notifier.cc
[add] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/connection_notifier.h
[add] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/connection_observer.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/crash_collector/arc_crash_collector_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/crash_collector/arc_crash_collector_bridge.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/ime/arc_ime_bridge_impl.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/ime/arc_ime_bridge_impl.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/instance_holder.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/intent_helper/arc_intent_helper_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/intent_helper/arc_intent_helper_bridge.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/lock_screen/arc_lock_screen_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/lock_screen/arc_lock_screen_bridge.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/metrics/arc_metrics_service.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/metrics/arc_metrics_service.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/midis/arc_midis_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/midis/arc_midis_bridge.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/net/arc_net_host_impl.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/net/arc_net_host_impl.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/obb_mounter/arc_obb_mounter_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/obb_mounter/arc_obb_mounter_bridge.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/power/arc_power_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/power/arc_power_bridge.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/rotation_lock/arc_rotation_lock_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/rotation_lock/arc_rotation_lock_bridge.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/volume_mounter/arc_volume_mounter_bridge.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/components/arc/volume_mounter/arc_volume_mounter_bridge.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/ui/arc/notification/arc_notification_manager.cc
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/ui/arc/notification/arc_notification_manager.h
[modify] https://crrev.com/ac2e551b4828308110853c2d143285c8c4a68bb3/ui/arc/notification/arc_notification_manager_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1c1cd3f721af72be0aee8b5201000ffd6b522a2

commit f1c1cd3f721af72be0aee8b5201000ffd6b522a2
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Nov 21 11:48:49 2017

Rename InstanceHolder to ConnectionHolder.

InstanceHolder will support full-duplex connection.
So, as its preparation, this CL rename it to
ConnectionHolder. Also InstanceHolder::has_instance()
is renamed to IsConnected().

BUG= 750563 
TEST=Ran bots.
TBR=oshima@chromium.org

Change-Id: I4dbb4ca8257e9e349c81f088b932552c995250dd
Reviewed-on: https://chromium-review.googlesource.com/775672
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518218}
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/chrome/browser/chromeos/arc/cast_receiver/arc_cast_receiver_service.cc
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner.cc
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service.cc
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/chrome/browser/chromeos/note_taking_helper.cc
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.h
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/chrome/browser/speech/tts_chromeos.cc
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/chrome/browser/sync/test/integration/sync_arc_package_helper.cc
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.cc
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.h
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/chrome/browser/ui/views/arc_app_dialog_view_browsertest.cc
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/components/arc/BUILD.gn
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/components/arc/arc_bridge_host_impl.cc
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/components/arc/arc_bridge_host_impl.h
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/components/arc/arc_bridge_service.h
[rename] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/components/arc/connection_holder.h
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/components/arc/connection_notifier.h
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/components/arc/intent_helper/activity_icon_loader.cc
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/components/arc/net/arc_net_host_impl.h
[modify] https://crrev.com/f1c1cd3f721af72be0aee8b5201000ffd6b522a2/ui/arc/notification/arc_notification_manager_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61350cba299e84239d215ff86c7cce2630b5f0e2

commit 61350cba299e84239d215ff86c7cce2630b5f0e2
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Nov 21 13:27:49 2017

Extract ConnectionHolderImpl.

ConnectionHolder will support full duplex connection in a following
CL. To switch the implementation between single direction connection
and full duplex connection, this CL introduces Impl class.

BUG= 750563 
TEST=Ran bots.

Change-Id: I2037f541b12a91ca5fe8e2b32b6b1fb59a5010a4
Reviewed-on: https://chromium-review.googlesource.com/776734
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518232}
[modify] https://crrev.com/61350cba299e84239d215ff86c7cce2630b5f0e2/components/arc/connection_holder.h

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e5ed8a614f99e62fb9d4dc019cb7b5d315528f5

commit 9e5ed8a614f99e62fb9d4dc019cb7b5d315528f5
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Nov 21 16:20:28 2017

Implement full duplex Mojo connection on ConnectionHolder.

Also, applies it to AppInstance/AppHost connection, as a first
use case.
Remaining will be done in following CLs.

BUG= 750563 
TEST=Ran bots.

Change-Id: Ie312d6b6f2421742fbd6f1db0dd75d8db5ea3bb6
Reviewed-on: https://chromium-review.googlesource.com/776742
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518270}
[modify] https://crrev.com/9e5ed8a614f99e62fb9d4dc019cb7b5d315528f5/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/9e5ed8a614f99e62fb9d4dc019cb7b5d315528f5/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.h
[modify] https://crrev.com/9e5ed8a614f99e62fb9d4dc019cb7b5d315528f5/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/9e5ed8a614f99e62fb9d4dc019cb7b5d315528f5/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/9e5ed8a614f99e62fb9d4dc019cb7b5d315528f5/chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.cc
[modify] https://crrev.com/9e5ed8a614f99e62fb9d4dc019cb7b5d315528f5/chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.h
[modify] https://crrev.com/9e5ed8a614f99e62fb9d4dc019cb7b5d315528f5/components/arc/arc_bridge_host_impl.cc
[modify] https://crrev.com/9e5ed8a614f99e62fb9d4dc019cb7b5d315528f5/components/arc/arc_bridge_host_impl.h
[modify] https://crrev.com/9e5ed8a614f99e62fb9d4dc019cb7b5d315528f5/components/arc/arc_bridge_service.cc
[modify] https://crrev.com/9e5ed8a614f99e62fb9d4dc019cb7b5d315528f5/components/arc/arc_bridge_service.h
[modify] https://crrev.com/9e5ed8a614f99e62fb9d4dc019cb7b5d315528f5/components/arc/connection_holder.h

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0c8e462bf029f31a7b9648ac2a5a4a54287d0cd

commit d0c8e462bf029f31a7b9648ac2a5a4a54287d0cd
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Wed Nov 22 06:02:17 2017

Set up full-duplex connection in ArcMetricsService::OnConnectionReady().

Preparation to migrate Init() invocation to ConnectionHolder.
In old implementation, OnConnectionReady() calls session_manager
to retrieve the ARC start time, then call Init() to avoid
race situation, because ReportBootProgress can be called
whenever after Init() is called.

With this CL, Init() is synchronously called in OnConnectionReady().
Instead, session_manager call is done for each ReportBootProgress call.
We expect it is called at most once per ARC container instance.

BUG= 750563 
TEST=Ran bots.

Change-Id: I77469858a2dec077f088747a167a56fb393c4e12
Reviewed-on: https://chromium-review.googlesource.com/782199
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518550}
[modify] https://crrev.com/d0c8e462bf029f31a7b9648ac2a5a4a54287d0cd/components/arc/metrics/arc_metrics_service.cc
[modify] https://crrev.com/d0c8e462bf029f31a7b9648ac2a5a4a54287d0cd/components/arc/metrics/arc_metrics_service.h

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b

commit 902e84f0e4cb6af6e8ea7de2e1862799fdc7686b
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Mon Nov 27 17:27:34 2017

Migrate arc::XxxInstance::Init() call to ConnectionHolder.

BUG= 750563 
TEST=Ran bots.

Change-Id: I118e7ff6325ea707a54bbcba2ac311cb9134cbb1
Reviewed-on: https://chromium-review.googlesource.com/782479
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519325}
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/auth/arc_auth_service.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/auth/arc_auth_service.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/boot_phase_monitor/arc_boot_phase_monitor_bridge.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/boot_phase_monitor/arc_boot_phase_monitor_bridge.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/enterprise/arc_cert_store_bridge.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/enterprise/arc_cert_store_bridge.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/enterprise/arc_enterprise_reporting_service.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/enterprise/arc_enterprise_reporting_service.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/fileapi/arc_file_system_bridge.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/fileapi/arc_file_system_bridge.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner_unittest.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/kiosk/arc_kiosk_bridge.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/kiosk/arc_kiosk_bridge.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/oemcrypto/arc_oemcrypto_bridge.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/oemcrypto/arc_oemcrypto_bridge.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/policy/arc_policy_bridge.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/print/arc_print_service.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/print/arc_print_service.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/tts/arc_tts_service.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/tts/arc_tts_service.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/video/gpu_arc_video_service_host.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/video/gpu_arc_video_service_host.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/chrome/browser/chromeos/note_taking_helper_unittest.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/arc_bridge_service.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/audio/arc_audio_bridge.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/audio/arc_audio_bridge.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/clipboard/arc_clipboard_bridge.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/clipboard/arc_clipboard_bridge.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/connection_holder.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/crash_collector/arc_crash_collector_bridge.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/crash_collector/arc_crash_collector_bridge.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/ime/arc_ime_bridge_impl.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/ime/arc_ime_bridge_impl.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/intent_helper/arc_intent_helper_bridge.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/intent_helper/arc_intent_helper_bridge.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/metrics/arc_metrics_service.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/metrics/arc_metrics_service.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/midis/arc_midis_bridge.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/midis/arc_midis_bridge.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/net/arc_net_host_impl.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/net/arc_net_host_impl.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/obb_mounter/arc_obb_mounter_bridge.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/obb_mounter/arc_obb_mounter_bridge.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/power/arc_power_bridge.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/components/arc/power/arc_power_bridge.h
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/ui/arc/notification/arc_notification_manager.cc
[modify] https://crrev.com/902e84f0e4cb6af6e8ea7de2e1862799fdc7686b/ui/arc/notification/arc_notification_manager.h

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/762d5038f37674a78a452dce4b92ad95470ecbca

commit 762d5038f37674a78a452dce4b92ad95470ecbca
Author: Luis Hector Chavez <lhchavez@google.com>
Date: Mon Nov 27 20:08:39 2017

arc: Add template classes to dispatch to the correct version of Init().

This change adds some template classes to dispatch to the best possible
implementation of Init() automatically. This means that if a class has
already migrated to the full-duplex Init(), it will invoke that version.
Otherwise it will fallback to the single-duplex one.

This also adds a static_assert() to avoid calling the single-duplex
version where there is a full-duplex one available.

BUG= 750563 
TEST=Compiles

Change-Id: Id5a10cb3678300ad6aad1c51b7b1cd3d445b918a
Reviewed-on: https://chromium-review.googlesource.com/783410
Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519377}
[modify] https://crrev.com/762d5038f37674a78a452dce4b92ad95470ecbca/components/arc/connection_holder.h

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc

commit 3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Nov 28 03:51:08 2017

Adds callback to Init().

For each XxxInstance interfaces that have Init(),
- Deprecate current Init() by renaming it to InitDeprecate(), and
- Introduce a new Init(), which has callback.

Unfortunately, whether the method has callback or not is
not versioned in Mojo. So, instead, deprecates old ones,
and adds new ones.

BUG= 750563 
TEST=Ran bots.

Change-Id: I48ea0a3b900ee998e01f3ea07e420cad610d07c8
Reviewed-on: https://chromium-review.googlesource.com/785434
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519554}
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/chrome/browser/chromeos/arc/enterprise/arc_cert_store_bridge_browsertest.cc
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/accessibility_helper.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/app.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/audio.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/auth.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/bluetooth.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/boot_phase_monitor.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/cert_store.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/clipboard.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/crash_collector.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/enterprise_reporting.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/file_system.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/ime.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/intent_helper.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/kiosk.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/metrics.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/midis.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/net.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/notifications.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/obb_mounter.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/oemcrypto.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/policy.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/power.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/print.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/tts.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/video.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/voice_interaction_arc_home.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/voice_interaction_framework.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/common/wallpaper.mojom
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/test/fake_app_instance.cc
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/test/fake_app_instance.h
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/test/fake_bluetooth_instance.cc
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/test/fake_bluetooth_instance.h
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/test/fake_file_system_instance.cc
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/test/fake_file_system_instance.h
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/test/fake_intent_helper_instance.cc
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/test/fake_intent_helper_instance.h
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/test/fake_notifications_instance.cc
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/test/fake_notifications_instance.h
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/test/fake_policy_instance.cc
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/test/fake_policy_instance.h
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/test/fake_power_instance.cc
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/test/fake_power_instance.h
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/test/fake_voice_interaction_framework_instance.cc
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/test/fake_voice_interaction_framework_instance.h
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/test/fake_wallpaper_instance.cc
[modify] https://crrev.com/3a2e64650754ed9a1cb47a18ee4d5f35d8cff1fc/components/arc/test/fake_wallpaper_instance.h

Status: Fixed (was: Started)
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/148156b3160e1ab571d853e04ceee4c4ff7c62a8

commit 148156b3160e1ab571d853e04ceee4c4ff7c62a8
Author: Luis Hector Chavez <lhchavez@google.com>
Date: Mon Oct 01 05:39:43 2018

arc: Deprecate InitDeprecated support in arc::ConnectionHolder

This change deletes a bunch of TMP that was required during the big
arc::ConnectionHolder refactoring of 2017.

Bug:  750563 
Test: build
Change-Id: Ibe6eaf55965a488855a9b306f1d79caff57646a3
Reviewed-on: https://chromium-review.googlesource.com/1253501
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595385}
[modify] https://crrev.com/148156b3160e1ab571d853e04ceee4c4ff7c62a8/components/arc/connection_holder.h

Sign in to add a comment