New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750558 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Select-on-add is broken

Reported by abom...@etouch.net, Jul 31 2017

Issue description

Chrome Version:62.0.3172.0 (Official Build) b86b4c08ea245b97bee78f06c41ddf98dacf6127-refs/heads/master@{#490684}
OS:Windows (7,8,10), Mac(10.12.3, 10.12.5, 10.11.6), Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://bookmarks/?id=1
2. Click on 'Star' icon to bookmark the page and then click on 'Organize' icon
3. Select 'Add Folder' option such that dialog box get open and click outside the dialog box.click on 'Save' button.
4. Observe.

Actual:Unnecessary bookmarks gets selected after step 3.
Expected: Bookmarks should not get selected after step 3.

This is regression issue, broken in 'M 62' and below is manual bisect info:
Good build: 62.0.3169.0
Bad build: 62.0.3170.0
 
Actual.mp4
416 KB View Download
Expected.mp4
292 KB View Download
Labels: hasbisect-per-revision
Owner: tsergeant@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:62.0.3169.0(Revision:490187).
Bad build:62.0.3170.0(Revision:490562).

You are probably looking for a change made after 490222 (known good), but no later than 490223 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/1fa8d19c60e8f878547f98feb6c04e8cdc1faa12..f42530c8a51162f2b510188de04752edf06a1345

From the CL above, assigning the issue to the concern owner

@tsergeant : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2977523002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.5 and Able to reproduce in latest Canary #62.0.3171.0
Labels: -Pri-1 Pri-2
Owner: calamity@chromium.org
Status: Started (was: Assigned)
Summary: Select-on-add is broken (was: Regression: Unnecessary bookmarks gets selected on clicking outside the dialog box.)
This is happening because the function trackItemsUpdated is being used instead of the boolean trackUpdated in api_listener.js
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6ac45fd042859d2240e5d432c521df01ad5b7bf

commit e6ac45fd042859d2240e5d432c521df01ad5b7bf
Author: Christopher Lam <calamity@google.com>
Date: Tue Aug 01 18:16:01 2017

[MD Bookmarks] Fix incorrect variable in api_listener.js.

This CL fixes an issue where a function that was being checked for truth
should actually have been a boolean.

Bug:  750558 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib3c9e2f71b865b86b6ff46cc1fb9be8c9bff11b4
Reviewed-on: https://chromium-review.googlesource.com/594946
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491056}
[modify] https://crrev.com/e6ac45fd042859d2240e5d432c521df01ad5b7bf/chrome/browser/resources/md_bookmarks/api_listener.js

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf6b85fc0c0b15ef69065a80518247b809ecceb3

commit cf6b85fc0c0b15ef69065a80518247b809ecceb3
Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org>
Date: Wed Aug 02 02:17:40 2017

Roll src/third_party/pdfium/ de7c9620c..33dd83089 (8 commits)

https://pdfium.googlesource.com/pdfium.git/+log/de7c9620c374..33dd830890d3

$ git log de7c9620c..33dd83089 --date=short --no-merges --format='%ad %ae %s'
2017-07-28 art-snake Add public access for read stream into CPDF_SyntaxParser
2017-08-01 art-snake Improve readability in CPDF_Parser::ObjectInfo.
2017-07-29 art-snake Implement read Session.
2017-08-01 thestig Change CPDF_Parser::GetIndirectBinary() to return a std::vector.
2017-08-01 thestig Encapsulate some CFX_Char members.
2017-07-31 thestig Add a regression test for FPDF_ImportPages().
2017-08-01 rharrison Remove support for negative params to ReleaseBuffer()
2017-08-01 rharrison Replace raw value for constant error value in string operations

Created with:
  roll-dep src/third_party/pdfium
BUG= 750558 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: If79ba8091cd9e9ad042b2cadf3ba9d476ca7da9b
Reviewed-on: https://chromium-review.googlesource.com/597212
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491223}
[modify] https://crrev.com/cf6b85fc0c0b15ef69065a80518247b809ecceb3/DEPS

Comment 7 by abom...@etouch.net, Aug 2 2017

Labels: TE-Verified-62.0.3174.0 TE-Verified-M62
Note: Above issue is fixed on latest Canary version: 62.0.3174.0 (Official Build) on Windows,Linux and Mac OS

Thanks you.
Actual.mp4
331 KB View Download

Sign in to add a comment