Select-on-add is broken
Reported by
abom...@etouch.net,
Jul 31 2017
|
||||
Issue descriptionChrome Version:62.0.3172.0 (Official Build) b86b4c08ea245b97bee78f06c41ddf98dacf6127-refs/heads/master@{#490684} OS:Windows (7,8,10), Mac(10.12.3, 10.12.5, 10.11.6), Linux(14.04 LTS) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://bookmarks/?id=1 2. Click on 'Star' icon to bookmark the page and then click on 'Organize' icon 3. Select 'Add Folder' option such that dialog box get open and click outside the dialog box.click on 'Save' button. 4. Observe. Actual:Unnecessary bookmarks gets selected after step 3. Expected: Bookmarks should not get selected after step 3. This is regression issue, broken in 'M 62' and below is manual bisect info: Good build: 62.0.3169.0 Bad build: 62.0.3170.0
,
Jul 31 2017
This is happening because the function trackItemsUpdated is being used instead of the boolean trackUpdated in api_listener.js
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6ac45fd042859d2240e5d432c521df01ad5b7bf commit e6ac45fd042859d2240e5d432c521df01ad5b7bf Author: Christopher Lam <calamity@google.com> Date: Tue Aug 01 18:16:01 2017 [MD Bookmarks] Fix incorrect variable in api_listener.js. This CL fixes an issue where a function that was being checked for truth should actually have been a boolean. Bug: 750558 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib3c9e2f71b865b86b6ff46cc1fb9be8c9bff11b4 Reviewed-on: https://chromium-review.googlesource.com/594946 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#491056} [modify] https://crrev.com/e6ac45fd042859d2240e5d432c521df01ad5b7bf/chrome/browser/resources/md_bookmarks/api_listener.js
,
Aug 1 2017
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/98073c826b6eb1b78f8dc695577d09d4ee9cf6b8 commit 98073c826b6eb1b78f8dc695577d09d4ee9cf6b8 Author: Lei Zhang <thestig@chromium.org> Date: Tue Aug 01 20:55:43 2017 Add a regression test for FPDF_ImportPages(). BUG= chromium:750558 Change-Id: I0d541c660c529b368f420d461a6eb1d81e42579a Reviewed-on: https://pdfium-review.googlesource.com/9730 Reviewed-by: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> [modify] https://crrev.com/98073c826b6eb1b78f8dc695577d09d4ee9cf6b8/fpdfsdk/fpdfppo_embeddertest.cpp [add] https://crrev.com/98073c826b6eb1b78f8dc695577d09d4ee9cf6b8/testing/resources/bug_750568.in [add] https://crrev.com/98073c826b6eb1b78f8dc695577d09d4ee9cf6b8/testing/resources/bug_750568.pdf
,
Aug 1 2017
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf6b85fc0c0b15ef69065a80518247b809ecceb3 commit cf6b85fc0c0b15ef69065a80518247b809ecceb3 Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org> Date: Wed Aug 02 02:17:40 2017 Roll src/third_party/pdfium/ de7c9620c..33dd83089 (8 commits) https://pdfium.googlesource.com/pdfium.git/+log/de7c9620c374..33dd830890d3 $ git log de7c9620c..33dd83089 --date=short --no-merges --format='%ad %ae %s' 2017-07-28 art-snake Add public access for read stream into CPDF_SyntaxParser 2017-08-01 art-snake Improve readability in CPDF_Parser::ObjectInfo. 2017-07-29 art-snake Implement read Session. 2017-08-01 thestig Change CPDF_Parser::GetIndirectBinary() to return a std::vector. 2017-08-01 thestig Encapsulate some CFX_Char members. 2017-07-31 thestig Add a regression test for FPDF_ImportPages(). 2017-08-01 rharrison Remove support for negative params to ReleaseBuffer() 2017-08-01 rharrison Replace raw value for constant error value in string operations Created with: roll-dep src/third_party/pdfium BUG= 750558 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: If79ba8091cd9e9ad042b2cadf3ba9d476ca7da9b Reviewed-on: https://chromium-review.googlesource.com/597212 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491223} [modify] https://crrev.com/cf6b85fc0c0b15ef69065a80518247b809ecceb3/DEPS
,
Aug 2 2017
Note: Above issue is fixed on latest Canary version: 62.0.3174.0 (Official Build) on Windows,Linux and Mac OS Thanks you. |
||||
►
Sign in to add a comment |
||||
Comment 1 by rbasuvula@chromium.org
, Jul 31 2017Owner: tsergeant@chromium.org
Status: Assigned (was: Unconfirmed)