New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750552 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted selection is seen on content settings edit dailouge

Project Member Reported by divya.pa...@techmahindra.com, Jul 31 2017

Issue description

Chrome Version: 62.0.3171.0
OS: Win

What steps will reproduce the problem?
1. Launch chrome>> Navigate to chrome://settings/>> Content settings>> Cookies
2.  Click on 3 Dot menu>> Edit>> Double click on the blank space below the separation line

Expected:
There should not be any unwanted selection 

Actual: 
Unwanted selection is seen beside Edit button

Note: Issue is reproducible for Cookies, notifications, Javscript, Flash, Images, Popus, Background sync, Automatic downloads, Unsandboxed plug-in access, 

Will update Linux info when its available

This is regression issue broken in M-61

Below is the manual bisect info:
=============================
Good Build: 61.0.3132.0 
Bad Build: 61.0.3133.0 

 
Actual_Unwanted selection.ogv
5.2 MB View Download
Expected_No Unwanted selection.ogv
2.4 MB View Download
Description: Show this description
Labels: OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce this issue on Ubuntu 14.04 and Mac OS 10.12.6 using chrome latest dev #61.0.3163.13 as well.
Labels: -M-62 M-61
Cc: gajendr...@samsung.com
Labels: -Needs-Bisect hasbisect-per-revision
Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)
Using per revision bisect providing bisect results below

Bisect Information:
--------------------
You are probably looking for a change made after 479981 (known good), but no later than 479982 (first known bad).

Change Log URL: 
-----------------
https://chromium.googlesource.com/chromium/src/+log/f5f880c3d9d32f6925c211cd4836701cd2a3cbb2..0721d307c2e650409d287b02ddeeed4d1635b086

dschuyler@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!!

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f18d851e8ab01caea383f41aed7a8debbb2f3533

commit f18d851e8ab01caea383f41aed7a8debbb2f3533
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Wed Aug 02 02:46:07 2017

[MD settings] remove parent div to align dialog buttons

This CL removes a few instances of a div with class="action-buttons".
The .action-buttons class doesn't appear to be defined and the wrapping
div disturbed the styling from the button-container (which has the
correct styling).

Bug:  750552 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6dec5daa83c6543c809e88ccd331c5ded08461a8
Reviewed-on: https://chromium-review.googlesource.com/595212
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491236}
[modify] https://crrev.com/f18d851e8ab01caea383f41aed7a8debbb2f3533/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/f18d851e8ab01caea383f41aed7a8debbb2f3533/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html
[modify] https://crrev.com/f18d851e8ab01caea383f41aed7a8debbb2f3533/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html

Status: Fixed (was: Assigned)
Labels: TE-Verified-62.0.3175.0 TE-Verified-M62
verified above issue on Mac(10.11.6, 10.12.3), Linux(14.04 LTS) OS on build #62.0.3175.0 and issue is fixed, it is working as intended.
Note: will soon update windows OS status once latest canary build is available.
Result.mov
3.9 MB Download

Sign in to add a comment