Regression: Profile icon turns blank on pressing TAB or mouse click.
Reported by
aiman.an...@etouch.net,
Jul 31 2017
|
||||||||||||
Issue descriptionChrome Version:62.0.3171.0 (Official Build)d82eb4601227635631686c93b5e9ac376ab8ee6f-refs/heads/master@{#490649}(64-bit) OS: Mac(10.11.6, 10.12.3), Win(7,8,10). Steps to reproduce: 1. Launch chrome, go to chrome://settings/people, click on Manage other people option. 2. On Add person overlay, press TAB and observe. Actual Result: Profile icon turns blank. Expected Result: Profile icon should not turn blank. This is Regression issue broken in M-62 and will soon update other bisect info. Manual Bisect Info: Good Build: 62.0.3169.0 Bad Build: 62.0.3170.0 Note: Will soon update Linux OS info.
,
Jul 31 2017
,
Jul 31 2017
Using the per-revision bisect providing the bisect results, Good build:62.0.3169.0(Revision:490187). Bad build:62.0.3170.0(Revision:490562). You are probably looking for a change made after 490556 (known good), but no later than 490557 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/4d9f08573ffcace0f52f3740bdf1dde28b11cccf..6a7b2c8b82779c0e1bf5b01b72b4dd5e7c28301e From the CL above, assigning the issue to the concern owner @reveman : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Reviewed-on: https://chromium-review.googlesource.com/591630 Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.5 and Able to reproduce in latest Canary #62.0.3171.0 Adding Release Block-Stable for this issue.Please remove if not the case.
,
Jul 31 2017
,
Aug 7 2017
,
Aug 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e50886210b79339937db96d906f321b85cd98026 commit e50886210b79339937db96d906f321b85cd98026 Author: David Reveman <reveman@chromium.org> Date: Mon Aug 07 20:54:00 2017 ui: Set animated image source correctly for non-MD user picker. Fix a two cases where non-MD user picker code is failing to set animatedImageElement src attribute. BUG= 750545 TBR=stevenjb@chromium.org TEST=chrome://settings/people -> "Manage other people" and press Tab Change-Id: I362eacb81b77136c10cec96c10d2b61c0e30640a Reviewed-on: https://chromium-review.googlesource.com/604129 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#492400} [modify] https://crrev.com/e50886210b79339937db96d906f321b85cd98026/ui/login/account_picker/user_pod_row.js [modify] https://crrev.com/e50886210b79339937db96d906f321b85cd98026/ui/login/account_picker/user_pod_template.html
,
Aug 7 2017
,
Aug 11 2017
Merge request for #6 as required for new default profile avatars (issue 721647).
,
Aug 11 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 11 2017
Per comment #8, CL listed #6 merge is needed for new default profile avatars (issue 721647) which is specific to Chrome OS. + ketakid@ and kbleicher@ for M61 merge review.
,
Aug 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c65a1c37669598ab9ffab76dca15915280e6ed7d commit c65a1c37669598ab9ffab76dca15915280e6ed7d Author: David Reveman <reveman@chromium.org> Date: Sat Aug 12 13:45:32 2017 ui: Set animated image source correctly for non-MD user picker. Fix a two cases where non-MD user picker code is failing to set animatedImageElement src attribute. BUG= 750545 TBR=reveman@chromium.org, stevenjb@chromium.org TEST=chrome://settings/people -> "Manage other people" and press Tab (cherry picked from commit e50886210b79339937db96d906f321b85cd98026) Change-Id: I362eacb81b77136c10cec96c10d2b61c0e30640a Reviewed-on: https://chromium-review.googlesource.com/604129 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#492400} Reviewed-on: https://chromium-review.googlesource.com/612198 Cr-Commit-Position: refs/branch-heads/3163@{#517} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/c65a1c37669598ab9ffab76dca15915280e6ed7d/ui/login/account_picker/user_pod_row.js [modify] https://crrev.com/c65a1c37669598ab9ffab76dca15915280e6ed7d/ui/login/account_picker/user_pod_template.html
,
Aug 14 2017
Per comment #11, this is already merged to M61.
,
Aug 16 2017
Note: Retested the above issue on #62.0.3187.0 on Linux(14.04 LTS), Mac(10.11.6, 10.12.3), Win(7,8,10). Fix is working as intended.
,
Aug 16 2017
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by aiman.an...@etouch.net
, Jul 31 2017