New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750521 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

DCHECK going off in fast_ink_view.cc(131)

Project Member Reported by dcasta...@chromium.org, Jul 30 2017

Issue description

When I enable the laser pointer mode, as soon as I touch the screen with a pen I get this:

[5947:5947:0730/171750.302110:FATAL:fast_ink_view.cc(131)] Check failed: resources.size() == 1u (2 vs. 1)


 
Cc: -reve...@chromium.org kaznacheev@chromium.org
Owner: reve...@chromium.org
Assigning to reveman@, as I have only moved the existing code around
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62590d7cb444ffafb9f55619770c0be4afeab924

commit 62590d7cb444ffafb9f55619770c0be4afeab924
Author: David Reveman <reveman@chromium.org>
Date: Sat Aug 12 23:13:01 2017

ash: Stop assuming only 1 resource is reclaimed in fastink code.

If we manage to produce frames fast enough then multiple
resources might be returned in one call to ReclaimResources.

BUG= 750521 
TBR=oshima@chromium.org

Change-Id: Iec1bb16c018ec8a1c2625dd7a1031522136e3554
Reviewed-on: https://chromium-review.googlesource.com/611676
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493984}
[modify] https://crrev.com/62590d7cb444ffafb9f55619770c0be4afeab924/ash/fast_ink/fast_ink_view.cc

Cc: dcasta...@chromium.org
Labels: Merge-Request-61
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 13 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge for M61 Chrome OS.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 14 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40990d7d84b54ecd78bd75fd8a15fdc54f155c39

commit 40990d7d84b54ecd78bd75fd8a15fdc54f155c39
Author: David Reveman <reveman@chromium.org>
Date: Mon Aug 14 18:26:06 2017

ash: Stop assuming only 1 resource is reclaimed in fastink code.

If we manage to produce frames fast enough then multiple
resources might be returned in one call to ReclaimResources.

BUG= 750521 
TBR=oshima@chromium.org, reveman@chromium.org

(cherry picked from commit 62590d7cb444ffafb9f55619770c0be4afeab924)

Change-Id: Iec1bb16c018ec8a1c2625dd7a1031522136e3554
Reviewed-on: https://chromium-review.googlesource.com/611676
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493984}
Reviewed-on: https://chromium-review.googlesource.com/614141
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#538}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/40990d7d84b54ecd78bd75fd8a15fdc54f155c39/ash/fast_ink/fast_ink_view.cc

Status: Fixed (was: Assigned)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment