New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750501 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in v8::Context::Global

Project Member Reported by ClusterFuzz, Jul 30 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4678226264981504

Fuzzer: ifratric-browserfuzzer-v3
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x00000000
Crash State:
  v8::Context::Global
  blink::ToExecutionContext
  blink::ExecutionContext::From
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=483281:483383

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4678226264981504


Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: msrchandra@chromium.org
Labels: M-62 Test-Predator-Wrong
Owner: yukishiino@chromium.org
Status: Assigned (was: Untriaged)
Predator could not provide any possible suspects.
Using the file, "ExecutionContext.cpp" assigning to the concern owner from the below CL --
https://chromium.googlesource.com/chromium/src/+log/14d5ed2dd6b7ca8b6eea5875c9c64e142846e4b6..ad4f36ac5736301cbb7c9c47e8810039f6e256e9?pretty=fuller

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/a5418786187f6af3327c9342845db1a32adfbbaf

@yukishiino -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Components: Blink>Bindings
Labels: -OS-Windows OS-All
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df80c6ec248b494ded0c32f0c5d3b1d1ae6c24a0

commit df80c6ec248b494ded0c32f0c5d3b1d1ae6c24a0
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Tue Aug 01 07:01:08 2017

v8binding: Fixes the order of ScriptState check in callback interfaces.

Checks the ScriptState before the use of the context (ExecutionContext::
From uses a context).

Bug:  750501 
Change-Id: Iae25998060667beb32c21fc3a33f2caf27b0bd21
Reviewed-on: https://chromium-review.googlesource.com/593532
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490893}
[modify] https://crrev.com/df80c6ec248b494ded0c32f0c5d3b1d1ae6c24a0/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
[modify] https://crrev.com/df80c6ec248b494ded0c32f0c5d3b1d1ae6c24a0/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp

Status: Fixed (was: Started)
Project Member

Comment 5 by ClusterFuzz, Aug 2 2017

ClusterFuzz has detected this issue as fixed in range 490887:490927.

Detailed report: https://clusterfuzz.com/testcase?key=4678226264981504

Fuzzer: ifratric-browserfuzzer-v3
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x00000000
Crash State:
  v8::Context::Global
  blink::ToExecutionContext
  blink::ExecutionContext::From
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=483281:483383
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=490887:490927

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4678226264981504


See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Labels: Merge-Request-61
Request a merge of #c5 to M61.
Correction: Request a merge of ** #c3 ** to M61.
Project Member

Comment 8 by ClusterFuzz, Aug 2 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4678226264981504 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Aug 3 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 3 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d75d703a208179368bac619065b3487573700800

commit d75d703a208179368bac619065b3487573700800
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Thu Aug 03 10:26:02 2017

v8binding: Fixes the order of ScriptState check in callback interfaces.

Checks the ScriptState before the use of the context (ExecutionContext::
From uses a context).

TBR=yukishiino@chromium.org

(cherry picked from commit df80c6ec248b494ded0c32f0c5d3b1d1ae6c24a0)

Bug:  750501 
Change-Id: Iae25998060667beb32c21fc3a33f2caf27b0bd21
Reviewed-on: https://chromium-review.googlesource.com/593532
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490893}
Reviewed-on: https://chromium-review.googlesource.com/599790
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#268}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/d75d703a208179368bac619065b3487573700800/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
[modify] https://crrev.com/d75d703a208179368bac619065b3487573700800/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp

Sign in to add a comment