New issue
Advanced search Search tips

Issue 750476 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

browser_tests failing on chromium.win/Win7 Tests (dbg)(1)

Project Member Reported by meade@chromium.org, Jul 30 2017

Issue description

browser_tests failing on chromium.win/Win7 Tests (dbg)(1)

Builders failed on: 
- Win7 Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29

Failing tests:
ProcessMemoryMetricsEmitterTest.FetchDuringTrace
ProcessMemoryMetricsEmitterTest.FetchAndEmitMetrics
ProcessMemoryMetricsEmitterTest.FetchThreeTimes

First failing build:https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61933

Log for failing test: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__dbg__1_%2F61933%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FProcessMemoryMetricsEmitterTest.FetchDuringTrace%2F0
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16169b07d2699afd7369f16176cae3447fed5499

commit 16169b07d2699afd7369f16176cae3447fed5499
Author: meade_UTC10 <meade@chromium.org>
Date: Sun Jul 30 05:07:15 2017

Revert "Plumb URLs through memory_instrumentation UKMs."

This reverts commit 1d8d254c7eb403770bfc310cb9abe3406fac9503.

Reason for revert: Broke
ProcessMemoryMetricsEmitterTest.FetchDuringTrace
ProcessMemoryMetricsEmitterTest.FetchAndEmitMetrics
ProcessMemoryMetricsEmitterTest.FetchThreeTimes

on chromium.win/Win7 Tests (dbg)(1)

First broken run: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61933


Original change's description:
> Plumb URLs through memory_instrumentation UKMs.
> 
> The URLs are obtained by creating a new interface CoordinationUnitIntrospector
> on the resource_coordinator service. The implementation of this interface crawls
> all ProcessCoordinationUnits, and creates a map from pid to hosted URLs by
> looking at associated FrameCoordinationUnits.
> 
> The interface for memory_instrumentation is modified slightly to include pid in
> ProcessMemoryDump to allow correlation between the memory dump and the URLs
> obtained from resource_coordinator. In a hypothetical future world where
> memory_instrumentation and resource_coordinator live in the same service, this
> can be removed.
> 
> Bug:730783
> 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> Change-Id: Ia1de1af692df4d7d08239db91c9fd14b71a15b70
> Reviewed-on: https://chromium-review.googlesource.com/578482
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490668}

TBR=avi@chromium.org,dcheng@chromium.org,thestig@chromium.org,primiano@chromium.org,rkaplow@chromium.org,erikchen@chromium.org,oysteine@chromium.org

Change-Id: I07a942b89aa22dcddd924fdcaeda025b6484b4eb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 730783, 750476 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Reviewed-on: https://chromium-review.googlesource.com/593267
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490682}
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/chrome/browser/DEPS
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/chrome/browser/metrics/process_memory_metrics_emitter.h
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/BUILD.gn
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[delete] https://crrev.com/9f67c851ed4af1217033c61254525f6fdcbc2202/services/resource_coordinator/coordination_unit/coordination_unit_introspector_impl.cc
[delete] https://crrev.com/9f67c851ed4af1217033c61254525f6fdcbc2202/services/resource_coordinator/coordination_unit/coordination_unit_introspector_impl.h
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/manifest.json
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/public/cpp/resource_coordinator_interface.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/public/cpp/resource_coordinator_interface.h
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/public/interfaces/BUILD.gn
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/public/interfaces/coordination_unit.mojom
[delete] https://crrev.com/9f67c851ed4af1217033c61254525f6fdcbc2202/services/resource_coordinator/public/interfaces/coordination_unit_introspector.mojom
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/public/interfaces/memory_instrumentation/memory_instrumentation.mojom
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/resource_coordinator_service.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/resource_coordinator_service.h

Comment 2 by meade@chromium.org, Jul 31 2017

Status: Fixed (was: Available)
The bots cycled green for a bit until failing with a different issue. Marking this bug as fixed.

Sign in to add a comment