New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750459 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Gray overlay seen on video elements

Reported by canb...@gmail.com, Jul 29 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3170.0 Safari/537.36

Example URL:
https://eksisozluk.com/video/gunun-videolari

Steps to reproduce the problem:
1. Gray parts are seen on video elements like in youtube or any other sites
2. Only in latest canary and dev (61-62)
3. Stable is not affected. 

What is the expected behavior?
There should no gray overlay or parts in the video.

What went wrong?
Gray overlay is seen. 

See the videos in : https://eksisozluk.com/video/gunun-videolari

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 62.0.3170.0  Channel: canary
OS Version: 10.0
Flash Version:
 
Untitled.jpg
115 KB View Download

Comment 1 by canb...@gmail.com, Jul 29 2017

https://www.youtube.com/watch?v=ihMJaxinoyY
Components: -Blink Blink>Media>Controls
Cc: kkaluri@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue on Windows 10 with chrome canary #62.0.3172.2, tested the issue as per steps mentioned in the comment #0

Didn't observed any gray parts while playing the videos.

Attaching the screen-cast for reference.

canblbn@ Could you retest the scenario on clean profile with no apps/extensions and let us know your observations.

Thank You...
750459.PNG
1.7 MB View Download

Comment 5 by canb...@gmail.com, Aug 1 2017

@kkaluri i tested with fresh profile with no addons. Still can see a gray lines and areas. they are very light gray oerlay but easily noticable. 

I have 2 graphics card on the ultrabook. So tried to run chrome with both of them. In both graphics card issue is reproducable.

It is not seen in stable beta (m60), bu can be seen on dev m61 and canary m62
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 1 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "kkaluri@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Needs-Triage-M62

Comment 8 by ajha@chromium.org, Aug 2 2017

Cc: ajha@chromium.org
Labels: -Type-Bug Needs-Bisect Needs-Feedback Type-Bug-Regression
Could you please attach the chrome://gpu details and also check if disabling 'Color correct rendering' from chrome://flags resolves the issue or not. 

Comment 9 by canb...@gmail.com, Aug 2 2017

Chrome://gpu page is attached.

Disabling color corrent rendering resolves the issue.

I also uploaded a screencast to drive: Here is the link.In the video difference between when Color correct rendering is disable and enabled is shown.

https://drive.google.com/file/d/0Bzsi_SbD22xuX3RBQnFkZ1JNM0U/view?usp=sharing
gpu.htm
159 KB View Download
Project Member

Comment 10 by sheriffbot@chromium.org, Aug 2 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "ajha@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by ajha@chromium.org, Aug 3 2017

Labels: -Pri-2 -Needs-Bisect ReleaseBlock-Stable M-61 Pri-1
Owner: ccameron@chromium.org
Status: Assigned (was: Unconfirmed)
As per C#9, this is resolved by disabling color correct rendering, hence assigning to ccameron@ for further inputs on this.  
Cc: hubbe@chromium.org
Labels: Needs-Feedback
canblbn, please attach the ICC color profile that you are using for your monitor.

I suspect that this is related to color conversion at composite time.

Comment 13 by canb...@gmail.com, Aug 3 2017

@ccameron 
Untitled.jpg
68.7 KB View Download
Untitled2.jpg
110 KB View Download
I'm looking for the actual .icc (or .icm) file -- you will probably be able to find it in C:\Windows\System32\spool\drivers\color -- it will have the file name that I've circled in red from your screenshot.
filename.jpg
75.2 KB View Download

Comment 15 by canb...@gmail.com, Aug 3 2017

@ccameron
CalibratedDisplayProfile-2.icc
9.9 KB Download
Thanks, I can now reproduce this issue locally on my machine. Taking a closer look.
This is my transfer function approximation code not being as exact as it should be. In particular, this allows that T(0)>0 because "it's no worse than the rest of the fit" ... but at 0, things matter a lot.

This should be easy enough to fix.
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f63bfb074ca169a59f112522dffb4a5fd7ff1a9a

commit f63bfb074ca169a59f112522dffb4a5fd7ff1a9a
Author: Christopher Cameron <ccameron@chromium.org>
Date: Sun Aug 06 21:12:25 2017

color: Make transfer function estimation robust to clamping

Transfer function tables encountered in the wild will often have the
property that they are a clamped parametric function.

In this particular bug, the parametric transfer function, when evaluted
at 1, is much greater than 1. The table clamps this value to 1. The
approximation code doesn't do any of this clamping, and so it ends up
with an inaccurate approximation.

Add a test with the data from the user-provided ICC profile.

Bug:  750459 
Change-Id: I520201d1610f50f5fbe0839116f405c07b10daf9
Reviewed-on: https://chromium-review.googlesource.com/602594
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492255}
[modify] https://crrev.com/f63bfb074ca169a59f112522dffb4a5fd7ff1a9a/ui/gfx/color_space_unittest.cc
[modify] https://crrev.com/f63bfb074ca169a59f112522dffb4a5fd7ff1a9a/ui/gfx/color_transform.cc
[modify] https://crrev.com/f63bfb074ca169a59f112522dffb4a5fd7ff1a9a/ui/gfx/skia_color_space_util.cc
[modify] https://crrev.com/f63bfb074ca169a59f112522dffb4a5fd7ff1a9a/ui/gfx/skia_color_space_util.h

Labels: Merge-Request-61
Adding merge request for M61.
Project Member

Comment 20 by sheriffbot@chromium.org, Aug 8 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
This is a very low risk fix for a bug in handling of unusual monitor profiles. Most of the lines in the patch are new tests.
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 branch 3163 based on comment #21. Please merge ASAP so we can take it in for tomorrow's Beta release. Thank you.
Project Member

Comment 23 by bugdroid1@chromium.org, Aug 8 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99a817e907e88fe39396aed4b03877d09cd654a9

commit 99a817e907e88fe39396aed4b03877d09cd654a9
Author: Christopher Cameron <ccameron@chromium.org>
Date: Tue Aug 08 17:54:43 2017

color: Make transfer function estimation robust to clamping

Transfer function tables encountered in the wild will often have the
property that they are a clamped parametric function.

In this particular bug, the parametric transfer function, when evaluted
at 1, is much greater than 1. The table clamps this value to 1. The
approximation code doesn't do any of this clamping, and so it ends up
with an inaccurate approximation.

Add a test with the data from the user-provided ICC profile.

TBR=ccameron@chromium.org

(cherry picked from commit f63bfb074ca169a59f112522dffb4a5fd7ff1a9a)

Bug:  750459 
Change-Id: I520201d1610f50f5fbe0839116f405c07b10daf9
Reviewed-on: https://chromium-review.googlesource.com/602594
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492255}
Reviewed-on: https://chromium-review.googlesource.com/606649
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#385}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/99a817e907e88fe39396aed4b03877d09cd654a9/ui/gfx/color_space_unittest.cc
[modify] https://crrev.com/99a817e907e88fe39396aed4b03877d09cd654a9/ui/gfx/color_transform.cc
[modify] https://crrev.com/99a817e907e88fe39396aed4b03877d09cd654a9/ui/gfx/skia_color_space_util.cc
[modify] https://crrev.com/99a817e907e88fe39396aed4b03877d09cd654a9/ui/gfx/skia_color_space_util.h

Status: Fixed (was: Assigned)

Sign in to add a comment