Repros for me on Mac 60.0.3112.78. More of a Privacy issue than a Security issue.

Deleted: Screen Shot 2017-07-30 at 1.28.00 PM.png 52.8 KB

	Screen Shot 2017-07-30 at 1.28.00 PM.png 52.8 KB View Download

dmurph@ -- assigning you as the owner based on other bugs in that component.
If you're not the right owner, please help triage and find them. Thanks.

Any estimate for when this will be fixed? Thanks.

ccing some more cookie people - we might have a bug in general with the session-only handling in storage partition?

Ping. dmurph@, can you follow up on this?

+jsbell@ for storage generally, and dullweber@ for clearing data.

+asvitkine@, FYI.

Repro steps from duplicated bug...

1. Navigate to chrome://settings/content/cookies
2. Next to "Clear on exit", click "Add", and add "https://rawgit.com" 
3. Visit https://rawgit.com/xchrdw/862c013b03edfa4ac43d44424f1bbeff/raw/886ed56b42f6b96b6d66986d4879521263457062/site_data_tester.html
4. Click 'Write"
5. Quit Chrome
6. Restart Chrome, visit the url from step 3

In tip-of-tree debug build I see cookies and cacheStorage. Given the variety of reports citing different storage types, maybe racy at shutdown?

Data deletion bugs are usually not treated as security issues, so I will remove the restriction.

CacheStorage was just missing the code entirely. WIP fix at https://chromium-review.googlesource.com/c/chromium/src/+/1288890

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba9595ea44ba3642804f90c072fd0976e8c68278

commit ba9595ea44ba3642804f90c072fd0976e8c68278
Author: Joshua Bell <jsbell@chromium.org>
Date: Fri Oct 19 14:32:30 2018

Cache Storage: Clear session-only origins on shutdown

Bug: 824533,750452
Change-Id: I103d6b6a3bd106a6a38de03f9ff14d2766c7b269
Reviewed-on: https://chromium-review.googlesource.com/c/1288890
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601141}
[modify] https://crrev.com/ba9595ea44ba3642804f90c072fd0976e8c68278/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
[modify] https://crrev.com/ba9595ea44ba3642804f90c072fd0976e8c68278/content/browser/cache_storage/cache_storage_context_impl.cc
[modify] https://crrev.com/ba9595ea44ba3642804f90c072fd0976e8c68278/content/browser/cache_storage/cache_storage_context_impl.h
[modify] https://crrev.com/ba9595ea44ba3642804f90c072fd0976e8c68278/content/browser/storage_partition_impl.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71626e0809d357a802049c0c82c0287ce4625772

commit 71626e0809d357a802049c0c82c0287ce4625772
Author: Joe Downing <joedow@chromium.org>
Date: Fri Oct 19 17:22:26 2018

Revert "Cache Storage: Clear session-only origins on shutdown"

This reverts commit ba9595ea44ba3642804f90c072fd0976e8c68278.

Reason for revert: Suspected of causing persistent BrowsingDataRemoverBrowserTest failure:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932222237758099792/+/steps/browser_tests_on_Windows-10-15063/0/logs/BrowsingDataRemoverBrowserTest.SessionOnlyStorageRemoved/0

This failure started after this CL was checked in and appears to be in the same area of code.  The failure is being seen on the Win10 Tests x64 builder:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64/28682

Original change's description:
> Cache Storage: Clear session-only origins on shutdown
> 
> Bug: 824533,750452
> Change-Id: I103d6b6a3bd106a6a38de03f9ff14d2766c7b269
> Reviewed-on: https://chromium-review.googlesource.com/c/1288890
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Ben Kelly <wanderview@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Commit-Queue: Joshua Bell <jsbell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601141}

TBR=jsbell@chromium.org,jam@chromium.org,pwnall@chromium.org,wanderview@chromium.org

Change-Id: Ia41455e70e5e89598fb1296cc539f143bda8295e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 824533, 750452
Reviewed-on: https://chromium-review.googlesource.com/c/1291781
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601202}
[modify] https://crrev.com/71626e0809d357a802049c0c82c0287ce4625772/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
[modify] https://crrev.com/71626e0809d357a802049c0c82c0287ce4625772/content/browser/cache_storage/cache_storage_context_impl.cc
[modify] https://crrev.com/71626e0809d357a802049c0c82c0287ce4625772/content/browser/cache_storage/cache_storage_context_impl.h
[modify] https://crrev.com/71626e0809d357a802049c0c82c0287ce4625772/content/browser/storage_partition_impl.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2cde601aae103875e231309861d9bde0754e8b0

commit d2cde601aae103875e231309861d9bde0754e8b0
Author: Joshua Bell <jsbell@chromium.org>
Date: Tue Nov 13 02:48:21 2018

Indexed DB: Avoid race in shutdown in clearing Session Only origins

Origins set to "clear on exit" need to get wiped when the storage
partition is shutting down. This was wired into the context's
destructor, but needed to be triggered earlier. Introduce an explicit
Shutdown() call invoked by the storage partition, similar to other
storage backends.

Bug: 750452, 824533
Change-Id: I353c183f842da0016fa35f7d48c462c5e85b67ab
Reviewed-on: https://chromium-review.googlesource.com/c/1289435
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607455}
[modify] https://crrev.com/d2cde601aae103875e231309861d9bde0754e8b0/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
[modify] https://crrev.com/d2cde601aae103875e231309861d9bde0754e8b0/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/d2cde601aae103875e231309861d9bde0754e8b0/content/browser/indexed_db/indexed_db_context_impl.h
[modify] https://crrev.com/d2cde601aae103875e231309861d9bde0754e8b0/content/browser/indexed_db/indexed_db_unittest.cc
[modify] https://crrev.com/d2cde601aae103875e231309861d9bde0754e8b0/content/browser/storage_partition_impl.cc