New issue
Advanced search Search tips

Issue 750446 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 82385



Sign in to add a comment

Two color-profile tests failing on WebKit Win tester after is_clang=true switch

Project Member Reported by thakis@chromium.org, Jul 29 2017

Issue description

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/24031

Unexpected Failures:
* images/color-profile-layer.html
* virtual/gpu-rasterization/images/color-profile-clip.html

Maybe just a race between rebaseline updates and something else?

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win10/24031/layout-test-results/results.html

^ diff looks extremely harmless.

So just needs a rebaseline I think.
 

Comment 1 by thakis@chromium.org, Jul 29 2017

Updated expectations in https://chromium-review.googlesource.com/c/593127/ (screwed up bug line though). We should still land a real rebaseline.

Comment 2 by h...@chromium.org, Jul 31 2017

Labels: clang
Owner: h...@chromium.org
Status: Started (was: Untriaged)
Giving it a shot here: https://chromium-review.googlesource.com/c/594927/
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6a4e6b297ca92a69fda171839cad1a6c470ae7f

commit d6a4e6b297ca92a69fda171839cad1a6c470ae7f
Author: Hans Wennborg <hans@chromium.org>
Date: Mon Jul 31 22:29:33 2017

Rebaseline two color-profile tests for Win10 bots after is_clang=true switch

I tried to follow the steps from
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/layout_test_expectations.md#Rebaselining-manually

- Marked the tests [ Rebaseline ] in TestExpectations
- Ran third_party/WebKit/Tools/Scripts/webkit-patch rebaseline-expectations
- This patch is the result.

BUG= 750446 

Change-Id: I37b764361139045b9321d3c9f781ef46ee459e8a
Reviewed-on: https://chromium-review.googlesource.com/594927
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490808}
[modify] https://crrev.com/d6a4e6b297ca92a69fda171839cad1a6c470ae7f/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/252600a1fd20c6fdf104c63e2f50272b94270388/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-layer-expected.png
[delete] https://crrev.com/252600a1fd20c6fdf104c63e2f50272b94270388/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-clip-expected.png
[modify] https://crrev.com/d6a4e6b297ca92a69fda171839cad1a6c470ae7f/third_party/WebKit/LayoutTests/platform/win/images/color-profile-layer-expected.png
[delete] https://crrev.com/252600a1fd20c6fdf104c63e2f50272b94270388/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-clip-expected.png
[delete] https://crrev.com/252600a1fd20c6fdf104c63e2f50272b94270388/third_party/WebKit/LayoutTests/platform/win7/images/color-profile-layer-expected.png
[delete] https://crrev.com/252600a1fd20c6fdf104c63e2f50272b94270388/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/images/color-profile-clip-expected.png
[rename] https://crrev.com/d6a4e6b297ca92a69fda171839cad1a6c470ae7f/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/color-profile-clip-expected.png

Comment 4 by h...@chromium.org, Aug 1 2017

Status: Fixed (was: Started)
https://build.chromium.org/p/chromium.webkit/console looks good

Sign in to add a comment