New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750438 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Stack-buffer-overflow in add_aa_span

Project Member Reported by ClusterFuzz, Jul 29 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5613929987571712

Fuzzer: afl_paint_op_buffer_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Stack-buffer-overflow READ 16
Crash Address: 0x7f49719a0ccb
Crash State:
  add_aa_span
  MaskSuperBlitter::blitH
  walk_edges
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=489460:489535

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5613929987571712


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 30 2017

Labels: M-61
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 30 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 30 2017

Labels: Pri-1

Comment 4 by vakh@chromium.org, Jul 31 2017

Cc: tomhud...@chromium.org reed@google.com
Components: Internals>Skia
Status: Available (was: Untriaged)
reed@, tomhudson@: Please help triage this bug and find the right owner. Thanks.
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 31 2017

Labels: -Security_Impact-Head Security_Impact-Beta

Comment 6 by vakh@chromium.org, Aug 1 2017

Cc: -reed@google.com
Owner: reed@google.com
Status: Assigned (was: Available)

Comment 7 by hcm@chromium.org, Aug 1 2017

Cc: -tomhud...@chromium.org hcm@chromium.org reed@google.com
Owner: liyuqian@chromium.org
FYI Skia bugs should be assigned to the developer if CL/code owner is obvious, or to Skia component for triage, or me.  tomhudson@ has not worked on Skia in some time, reed@ is out and sometimes overused...don't want these to get lost in the mix!

Sending to Yuqian to see if he sees anything in the AA code...
Labels: -M-61 M-62
Project Member

Comment 9 by ClusterFuzz, Aug 2 2017

ClusterFuzz has detected this issue as fixed in range 491156:491274.

Detailed report: https://clusterfuzz.com/testcase?key=5613929987571712

Fuzzer: afl_paint_op_buffer_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Stack-buffer-overflow READ 16
Crash Address: 0x7f49719a0ccb
Crash State:
  add_aa_span
  MaskSuperBlitter::blitH
  walk_edges
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=489460:489535
Fixed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=491156:491274

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5613929987571712


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Aug 2 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5613929987571712 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Aug 2 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 15 2017

Labels: Merge-Request-62
Project Member

Comment 13 by sheriffbot@chromium.org, Sep 15 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-62
Clusterfuzz noted this is fixed in M62
Labels: -ReleaseBlock-Stable
Project Member

Comment 16 by sheriffbot@chromium.org, Nov 8 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment