New issue
Advanced search Search tips

Issue 750434 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug


Sign in to add a comment

roll clang again

Project Member Reported by thakis@chromium.org, Jul 29 2017

Issue description

r309422 fixes the compiler crash from bug 749273.
r309343 fixes the miscompile from  bug 749826 .
r308997 adds -nostdlib++.
r308998 makes lld not write .manifest files all over the place.

Nothing extremely critical yet, but enough to at least file a tracking bug for the next roll :-)

inglorion, would you be interested in trying to do a roll?
 

Comment 1 by h...@chromium.org, Jul 31 2017

Blocking: 749826

Comment 2 by thakis@chromium.org, Jul 31 2017

Blockedon: 750700

Comment 3 by thakis@chromium.org, Jul 31 2017

Blockedon: 750722

Comment 4 by thakis@chromium.org, Jul 31 2017

Blocking: 749813
r309628 for  bug 749813 
r309611 fix for mips msa simd

Comment 6 by p...@chromium.org, Jul 31 2017

Cc: vtsyrklevich@chromium.org p...@chromium.org
r309635 for CFI bug fixes.
Blocking: 751313
Blockedon: 751385
Blockedon: 751360
Blocking: libyuv:715
Blocking: 751225
309984 for  bug 751225 
I tried 309984 yesterday, but tests fail on win. filed https://bugs.llvm.org/show_bug.cgi?id=34064 for that.
https://chromium-review.googlesource.com/c/600860 is looking pretty good except for some cfi stuff
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4bc163e7ceb1ffc00fc20efbd92316635b984fe

commit c4bc163e7ceb1ffc00fc20efbd92316635b984fe
Author: Nico Weber <thakis@chromium.org>
Date: Sun Aug 06 13:29:39 2017

Roll clang 308728:309984.

Ran `tools/clang/scripts/upload_revision.py 309984`.

Also switch to gnuwin-7, which is identical to gnuwin-6 except
it also contains [.exe and false.exe (needed by the newly-enabled
lit shell tests -- only lit's unit tests need these two binaries,
LLVM's actual tests don't).

Also contains a workaround for an upstream CFI regression. This
should be reverted in the next clang roll, which has an upstream
fix.

Bug:  750434 
Change-Id: Ibd5a6f5fee3ee011c7a7269e4a7601f0e9259135
Reviewed-on: https://chromium-review.googlesource.com/600860
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492253}
[modify] https://crrev.com/c4bc163e7ceb1ffc00fc20efbd92316635b984fe/tools/cfi/blacklist.txt
[modify] https://crrev.com/c4bc163e7ceb1ffc00fc20efbd92316635b984fe/tools/clang/scripts/update.py

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff69d3018c42eb994533de337f81d417a0209913

commit ff69d3018c42eb994533de337f81d417a0209913
Author: Nico Weber <thakis@chromium.org>
Date: Wed Aug 09 18:12:04 2017

Use clang's spiffy new -nostdlib++.

Reverts some Fuchsia bits of https://chromium-review.googlesource.com/c/582074

Also only default use_custom_libcxx to true on Linux if is_clang
(which on our bots is always the case), so that we can assume that
this flag is available.  (If gcc ever adds a -nostdlib++ flag, we
can undo this part.)

Bug:  750434 , 724204 
Change-Id: Ib548b403703f6dc77e5ec09c7ee14e360fb09b72
Reviewed-on: https://chromium-review.googlesource.com/606790
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493055}
[modify] https://crrev.com/ff69d3018c42eb994533de337f81d417a0209913/build/config/c++/c++.gni
[modify] https://crrev.com/ff69d3018c42eb994533de337f81d417a0209913/build/config/fuchsia/BUILD.gn
[modify] https://crrev.com/ff69d3018c42eb994533de337f81d417a0209913/build/config/posix/BUILD.gn

Owner: thakis@chromium.org
Status: Fixed (was: Untriaged)
Looks like this stuck.

(But we already want another roll, it looks like.)
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/695966bcd6b2698201c517c0e5af623f7028e388

commit 695966bcd6b2698201c517c0e5af623f7028e388
Author: Nico Weber <thakis@chromium.org>
Date: Wed Aug 09 19:07:59 2017

linux: Lower libc expectations after libstdlib++ change.

https://chromium-review.googlesource.com/c/606790 made it so we no longer
explicitly pass -lc.  Apparently manually adding -lc picks up the C library
from a slighly different place somehow (?)

Bug:  750434 , 724204 
Change-Id: I6a60a07c909842a88dcc4e670976b4b848866216
Reviewed-on: https://chromium-review.googlesource.com/609182
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493083}
[modify] https://crrev.com/695966bcd6b2698201c517c0e5af623f7028e388/chrome/installer/linux/debian/expected_deps_x64
[modify] https://crrev.com/695966bcd6b2698201c517c0e5af623f7028e388/chrome/installer/linux/rpm/expected_deps_x86_64

Sign in to add a comment