New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750420 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in GrTextUtils::DrawPosTextAsPath

Project Member Reported by ClusterFuzz, Jul 29 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5246363599372288

Fuzzer: afl_paint_op_buffer_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x6140000001f8
Crash State:
  GrTextUtils::DrawPosTextAsPath
  GrAtlasTextContext::drawPosText
  GrRenderTargetContext::drawPosText
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=489460:489535

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5246363599372288


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 29 2017

Labels: M-61
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 29 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 29 2017

Labels: Pri-1

Comment 4 by vakh@chromium.org, Jul 30 2017

Components: Internals>Skia
Owner: jvanverth@chromium.org
Status: Assigned (was: Untriaged)
jvanverth@ -- can you please help triage this. The regression range is useless.
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 30 2017

Labels: -Security_Impact-Head Security_Impact-Beta
My suspicion is that this is related to  bug 749472 . I'll take a look.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/1380bb47ab14569a0c1920ae7367fb4360b92bb8

commit 1380bb47ab14569a0c1920ae7367fb4360b92bb8
Author: Jim Van Verth <jvanverth@google.com>
Date: Mon Jul 31 18:55:12 2017

Don't draw text with zero glyph counts as paths

Bug:  chromium:750420 
Change-Id: Ie1a62356a3263c440a94ba1fd637c12884465515
Reviewed-on: https://skia-review.googlesource.com/28862
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>

[modify] https://crrev.com/1380bb47ab14569a0c1920ae7367fb4360b92bb8/src/gpu/text/GrTextUtils.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 9 by sheriffbot@chromium.org, Aug 1 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable -M-61 M-62
Project Member

Comment 11 by ClusterFuzz, Aug 2 2017

ClusterFuzz has detected this issue as fixed in range 490999:491077.

Detailed report: https://clusterfuzz.com/testcase?key=5246363599372288

Fuzzer: afl_paint_op_buffer_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x6140000001f8
Crash State:
  GrTextUtils::DrawPosTextAsPath
  GrAtlasTextContext::drawPosText
  GrRenderTargetContext::drawPosText
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=489460:489535
Fixed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=490999:491077

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5246363599372288


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Aug 2 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5246363599372288 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 13 by sheriffbot@chromium.org, Sep 15 2017

Labels: Merge-Request-62
Project Member

Comment 14 by sheriffbot@chromium.org, Sep 15 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-62
Already in M62
Project Member

Comment 16 by sheriffbot@chromium.org, Nov 7 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment