Issue metadata
Sign in to add a comment
|
Hard-coded borders in extension popups are bugged
Reported by
thereald...@gmail.com,
Jul 29 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3169.0 Safari/537.36 Steps to reproduce the problem: 1. Install https://chrome.google.com/webstore/detail/stylus/clngdbkpkpeebahjckkjfobafhncgmne 2. Install https://userstyles.org/styles/142097/stylus-gray-matter-chromium-based-or-firefox 3. Click icon to open popup What is the expected behavior? Previously, there was a hard-coded thick white border, or background which served the same purpose, all the way around the popup. What went wrong? Borders are on top and bottom, but none on the sides. Did this work before? Yes 60 Chrome version: 62.0.3169.0 Channel: canary OS Version: 6.3 Flash Version: I really hope you get rid of them altogether because they're stupid looking IMO. A lot of other forks like Vivaldi and Opera don't have them, and it looks a lot cleaner. Either way, there shouldn't be thick borders on the top and bottom and none on the sides. It looks silly. The example provided is just so the popup is dark, so it'll be more noticeable.
,
Jul 29 2017
P.S. r489381 initially landed in 62.0.3167.0
,
Aug 1 2017
As per comment #1, assigning into estade@ for further triage.
,
Aug 1 2017
Neither one of these screenshots looks particularly good. If you're worried about matching the border, you will have to use a white bg for the extension popup. Long term, we'd like to resolve this by fixing bug 713359.
,
Aug 1 2017
@estade, can you please tell us what's inside bug 713359? It's not public. As for a workaround for the time being, I guess manually adding white vertical borders might work inside the popup body.
,
Aug 1 2017
sorry, don't know why it's hidden. It's about making layer masks work on Windows.
,
Nov 21 2017
Issue 786894 has been merged into this issue.
,
Jan 30 2018
1. With this change extensions' popups with dark background now look ugly. 2. I've tried to fix the issue by determining if Chrome version is later than 62.0.3169.0 and added white 2px borders at left and right. I've noticed artifacts at right border when DPI scale is 125% or 150% (see the screenshot). 3. There are all 4 white borders present on Mac, but only 2 on Windows. 4. Why "WontFix"?
,
Mar 22 2018
I've noticed that there are no borders in Chrome Canary. Could anyone please give a version number so it would be possible to detect the change by script?
,
Mar 22 2018
re #9: see comment 2.
,
Mar 22 2018
re #10: This referred to missing left and right borders, now there are no borders at all.
,
Mar 22 2018
Oh I see, they've fixed the blocking bug 713359 referenced above. The fix is r543785 (Chrome 67.0.3373.0).
,
Mar 22 2018
Just checked Chrome Canary on Mac: now popup has top and bottom borders only. So, what we have now: 1. Chrome 65, Windows - top and bottom borders with arrow 2. Chrome 65, Mac - all 4 borders (thin) with arrow 3. Chrome 67, Windows - no borders, no arrow 4. Chrome 67, Mac - top and bottom borders (thick) without arrow 5. Firefox - no borders, arrow is colored with `<body>` color Please, make it the same on all platforms, remove all borders, take arrow color from `<html>` or `<body>`
,
Mar 23 2018
Chrome 67 on windows has the desired behavior. We aren't planning on bringing the arrow back, and Mac sometimes diverges from other platforms but hopefully will get updated eventually (artifact of the different UI toolkits we use between Mac and !Mac).
,
May 30 2018
@estade You told that Chrome 67 for Windows had the desired behavior, but today Chrome 67 stable was shipped and it adds 2px borders at top and border (Chrome 67 Canary for Windows had no borders). Please, let the extension author decide what to show in popup.
,
May 30 2018
@shuto, it was reverted just a week ago for HighDPI only due to a bug with DPI > 100% (the contents was blurred). |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by woxxom@gmail.com
, Jul 29 20179.1 KB
9.1 KB View Download