New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750410 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Password protection service feature name mismatch

Project Member Reported by jialiul@chromium.org, Jul 29 2017

Issue description

In PasswordProtectionService::CanSendPing(..), 
kPasswordFieldOnFocusPinging feature is mistakenly used in checking pinging status. 

As a result, the effective user pool of password reuse study is the same as password on focus study (a.k.a SBER and no incognito).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8d36f808bba639cbf37d1bf550c7036419cdbe8

commit c8d36f808bba639cbf37d1bf550c7036419cdbe8
Author: Jialiu Lin <jialiul@chromium.org>
Date: Tue Aug 01 08:56:27 2017

Fix Password Protection finch feature mismatch

kPasswordFieldOnFocusPinging feature was mistakenly used in checking pinging
status for password reuse study. 
As a result, the effective user pool of password reuse study is the same as
password on focus study (a.k.a SBER and no incognito).

Bug:  750410 
Change-Id: I2579f5b5119ccfb68074b735d814dc3c8efa4a75
Reviewed-on: https://chromium-review.googlesource.com/592790
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490921}
[modify] https://crrev.com/c8d36f808bba639cbf37d1bf550c7036419cdbe8/components/safe_browsing/password_protection/BUILD.gn
[modify] https://crrev.com/c8d36f808bba639cbf37d1bf550c7036419cdbe8/components/safe_browsing/password_protection/password_protection_service.cc
[modify] https://crrev.com/c8d36f808bba639cbf37d1bf550c7036419cdbe8/components/safe_browsing/password_protection/password_protection_service.h
[modify] https://crrev.com/c8d36f808bba639cbf37d1bf550c7036419cdbe8/components/safe_browsing/password_protection/password_protection_service_unittest.cc

Labels: Merge-Request-61
Status: Fixed (was: Assigned)
Labels: M-61
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 2 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls merge you change to M61 branch 3163 by 5:00 PM PT, Friday (08/04) so we can take it in for next week M61 Beta release. Thank you.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 3 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccc85882615387c6e5c255bb67a39dcc37d992e1

commit ccc85882615387c6e5c255bb67a39dcc37d992e1
Author: Jialiu Lin <jialiul@chromium.org>
Date: Thu Aug 03 20:10:21 2017

Fix Password Protection finch feature mismatch

kPasswordFieldOnFocusPinging feature was mistakenly used in checking pinging
status for password reuse study.
As a result, the effective user pool of password reuse study is the same as
password on focus study (a.k.a SBER and no incognito).

TBR=jialiul@chromium.org

(cherry picked from commit c8d36f808bba639cbf37d1bf550c7036419cdbe8)

Bug:  750410 
Change-Id: I2579f5b5119ccfb68074b735d814dc3c8efa4a75
Reviewed-on: https://chromium-review.googlesource.com/592790
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490921}
Reviewed-on: https://chromium-review.googlesource.com/601087
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#282}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/ccc85882615387c6e5c255bb67a39dcc37d992e1/components/safe_browsing/password_protection/BUILD.gn
[modify] https://crrev.com/ccc85882615387c6e5c255bb67a39dcc37d992e1/components/safe_browsing/password_protection/password_protection_service.cc
[modify] https://crrev.com/ccc85882615387c6e5c255bb67a39dcc37d992e1/components/safe_browsing/password_protection/password_protection_service.h
[modify] https://crrev.com/ccc85882615387c6e5c255bb67a39dcc37d992e1/components/safe_browsing/password_protection/password_protection_service_unittest.cc

Sign in to add a comment