New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750404 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Codesearch history view truncates commit messages

Project Member Reported by mbjorge@chromium.org, Jul 29 2017

Issue description

In the history tab on codesearch, if a commit message is too long it gets truncated (e.g. #12 in https://cs.chromium.org/chromium/src/components/os_crypt/os_crypt_linux.cc cuts off at Review-Url: https://cod)

It would be most delightful if the commit message wasn't cut off at all, but at the very least it would be helpful if the code review url did not get cut off, since that's usually where I want to go when I'm investigating an issue from a CL

Perhaps if the truncation is necessary codesearch could trim out the middle bits and preserve the begining and the end?
 
Components: Infra>Codesearch

Comment 2 by flyboy@google.com, Nov 10 2017

Fair point.  However, don't forget that you can also get there by clicking on the Gitiles link (on the top line of the history entry).  From there it's just two more clicks to get to the review.

Comment 3 by j...@chromium.org, May 14 2018

Status: Available (was: Untriaged)

Sign in to add a comment