New issue
Advanced search Search tips

Issue 750403 link

Starred by 1 user
Status: Fixed
Owner:
sa...@chromium.org
Closed: Nov 23
Cc:
sdantul...@chromium.org
dhadd...@chromium.org
abod...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Files App>General information page preview is shown for the selection of multiple images.

Project Member Reported by mkarkada@chromium.org, Jul 29 2017 
Chrome OS Version: M62 (62.0.3166.0 dev build)
Chrome OS Platform: 9784.0.0 dev channel 
cave device

Steps To Reproduce:
(1) Goto Files App> select 2 images
(2) Select 3-dot menu, Get Info option is disabled
(3) Right click on the selected images (context menu list), Get Info option is disabled
(4) Click on the space bar, Get Info preview of the first image is shown.

Expected Result:
When both the 3-dot menu and context menu Get Info option is disabled, General information page preview should not be shown for the selection of multiple images.

Please do refer the video
Jul 28 2017 5-00 PM.webm
4.8 MB View Download

Comment 1 by weifangsun@chromium.org, Nov 16 2017

Labels: -M-62

Comment 2 by sashab@chromium.org, Feb 23 2018

Labels: CrOS-FilesApp-QuickView

Comment 3 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-QuickView CrOSFilesFeature-QuickView

Comment 4 by sashab@chromium.org, Apr 12 2018

Labels: -Pri-2 Hotlist-GoodFirstBug Pri-3
Status: Available (was: Untriaged)

Comment 5 by weifangsun@chromium.org, Nov 7

Labels: Files-Fixit-2018
Owner: weifangsun@chromium.org
Status: Assigned (was: Available)

Comment 6 by sa...@chromium.org, Nov 22

Owner: sa...@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9de4dc8e06f9794dff3d838f36b98ca32eb6ec32

commit 9de4dc8e06f9794dff3d838f36b98ca32eb6ec32
Author: Sam McNally <sammc@chromium.org>
Date: Fri Nov 23 03:05:05 2018

Only open quickview if exactly 1 file is selected.

Always invoke preventDefault() to avoid the default page-down from
triggering.

Bug:  750403 
Change-Id: I7b8779a8bd51757192c9c1534f25d9d574ca5cc5
Reviewed-on: https://chromium-review.googlesource.com/c/1348878
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610523}
[modify] https://crrev.com/9de4dc8e06f9794dff3d838f36b98ca32eb6ec32/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/9de4dc8e06f9794dff3d838f36b98ca32eb6ec32/ui/file_manager/file_manager/foreground/js/quick_view_controller.js
[modify] https://crrev.com/9de4dc8e06f9794dff3d838f36b98ca32eb6ec32/ui/file_manager/integration_tests/file_manager/quick_view.js

Comment 8 by sa...@chromium.org, Nov 23

Status: Fixed (was: Assigned)
►

Sign in to add a comment