New issue
Advanced search Search tips

Issue 750375 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR



Sign in to add a comment

WebVR: add feature flag to disable VSync aligned timing

Project Member Reported by klausw@chromium.org, Jul 28 2017

Issue description

The VSync-aligned timing introduced by r47449 (crrev.com/513662) is unhelpful for benchmarking, and external developers have requested a way to turn this off for comparison purposes. We should expose a feature flag to do so.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4cf0fdb7983a169b84478abac507700d4ae5621

commit a4cf0fdb7983a169b84478abac507700d4ae5621
Author: Klaus Weidner <klausw@chromium.org>
Date: Tue Aug 08 20:16:37 2017

Add webvr-vsync-align feature flag

The VSync-aligned timing introduced by r47449 (crrev.com/513662) is
unhelpful for benchmarking, and external developers have requested a
way to turn this off for comparison purposes.

BUG= 750375 
R=mthiesse@chromium.org, nick@chromium.org

Change-Id: I012492c3fca922067dccfb046d6f695edfe0573f
Reviewed-on: https://chromium-review.googlesource.com/592311
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492741}
[modify] https://crrev.com/a4cf0fdb7983a169b84478abac507700d4ae5621/chrome/browser/about_flags.cc
[modify] https://crrev.com/a4cf0fdb7983a169b84478abac507700d4ae5621/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/a4cf0fdb7983a169b84478abac507700d4ae5621/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/a4cf0fdb7983a169b84478abac507700d4ae5621/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/a4cf0fdb7983a169b84478abac507700d4ae5621/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/a4cf0fdb7983a169b84478abac507700d4ae5621/content/public/common/content_features.cc
[modify] https://crrev.com/a4cf0fdb7983a169b84478abac507700d4ae5621/content/public/common/content_features.h
[modify] https://crrev.com/a4cf0fdb7983a169b84478abac507700d4ae5621/tools/metrics/histograms/enums.xml

Labels: -M-61 M-62
Status: Fixed (was: Started)
This is included in today's canary 62.0.3180.0. Adjusting milestone to M62 since I think there's no current plans to cherrypick this to M61.
Labels: Proj-VR
Components: Blink>WebXR

Sign in to add a comment