Refactor test files and remove view_controllers dependencies.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4d25e6a412e1c1a5870bfa4977e47c70533cd37 commit b4d25e6a412e1c1a5870bfa4977e47c70533cd37 Author: Menglu Huang <huangml@chromium.org> Date: Wed Aug 09 18:15:08 2017 Remove view controller dependencies on tab_usage_recorder_egtest.mm We want to remove earlgrey test dependencies on view controllers and use common methods to prepare for EarlGrey2.0. Bug: 750372 Change-Id: I732acf3b9a2f18f73a37365a3f2444ea5235bb28 Reviewed-on: https://chromium-review.googlesource.com/592070 Reviewed-by: Mike Baxley <baxley@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Menglu Huang <huangml@chromium.org> Cr-Commit-Position: refs/heads/master@{#493057} [modify] https://crrev.com/b4d25e6a412e1c1a5870bfa4977e47c70533cd37/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm [modify] https://crrev.com/b4d25e6a412e1c1a5870bfa4977e47c70533cd37/ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm [modify] https://crrev.com/b4d25e6a412e1c1a5870bfa4977e47c70533cd37/ios/chrome/test/earl_grey/chrome_matchers.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/105da04ee97cd3c79b55f13a2f20920c3e1fe972 commit 105da04ee97cd3c79b55f13a2f20920c3e1fe972 Author: Mike Baxley <baxley@chromium.org> Date: Thu Aug 10 02:17:01 2017 Revert "Remove view controller dependencies on tab_usage_recorder_egtest.mm" This reverts commit b4d25e6a412e1c1a5870bfa4977e47c70533cd37. Reason for revert: This looks to break the downstream multitasking tests. Original change's description: > Remove view controller dependencies on tab_usage_recorder_egtest.mm > > We want to remove earlgrey test dependencies on view controllers and use common > methods to prepare for EarlGrey2.0. > > Bug: 750372 > Change-Id: I732acf3b9a2f18f73a37365a3f2444ea5235bb28 > Reviewed-on: https://chromium-review.googlesource.com/592070 > Reviewed-by: Mike Baxley <baxley@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Commit-Queue: Menglu Huang <huangml@chromium.org> > Cr-Commit-Position: refs/heads/master@{#493057} TBR=justincohen@chromium.org,olivierrobin@chromium.org,baxley@chromium.org,huangml@chromium.org Change-Id: Ib560608c02edad53f501dd8a934a669f7bef4786 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 750372 Reviewed-on: https://chromium-review.googlesource.com/609407 Reviewed-by: Mike Baxley <baxley@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#493232} [modify] https://crrev.com/105da04ee97cd3c79b55f13a2f20920c3e1fe972/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm [modify] https://crrev.com/105da04ee97cd3c79b55f13a2f20920c3e1fe972/ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm [modify] https://crrev.com/105da04ee97cd3c79b55f13a2f20920c3e1fe972/ios/chrome/test/earl_grey/chrome_matchers.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8aae00865ea9dbeead69c014b503856c4de6a07c commit 8aae00865ea9dbeead69c014b503856c4de6a07c Author: Menglu Huang <huangml@chromium.org> Date: Fri Aug 18 21:37:19 2017 Remove unused controller imports from translate_egtest.mm This view_controller file is not referred. Bug: 750372 Tbr: droger@chromium.org Change-Id: Ie0b1df6960ff85a9535a84f3f5f30b92271cebc9 Reviewed-on: https://chromium-review.googlesource.com/592331 Commit-Queue: Menglu Huang <huangml@chromium.org> Reviewed-by: Mike Baxley <baxley@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#495695} [modify] https://crrev.com/8aae00865ea9dbeead69c014b503856c4de6a07c/ios/chrome/browser/translate/translate_egtest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91bd56ff86e07a34c08810066bc5f493bb8bc286 commit 91bd56ff86e07a34c08810066bc5f493bb8bc286 Author: Menglu Huang <huangml@chromium.org> Date: Tue Aug 22 18:38:26 2017 Remove viewcontroller dependencies on payment egtests Bug: 750372 Change-Id: If55d9aff5f174b195994b33f80904bd5bd3118a0 Reviewed-on: https://chromium-review.googlesource.com/617390 Commit-Queue: Menglu Huang <huangml@chromium.org> Reviewed-by: Mike Baxley <baxley@chromium.org> Reviewed-by: mahmadi (Moe) <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#496381} [modify] https://crrev.com/91bd56ff86e07a34c08810066bc5f493bb8bc286/ios/chrome/browser/ui/payments/payment_request_accessibility_egtest.mm [modify] https://crrev.com/91bd56ff86e07a34c08810066bc5f493bb8bc286/ios/chrome/browser/ui/payments/payment_request_cancel_pay_abort_egtest.mm [modify] https://crrev.com/91bd56ff86e07a34c08810066bc5f493bb8bc286/ios/chrome/browser/ui/payments/payment_request_debit_egtest.mm [modify] https://crrev.com/91bd56ff86e07a34c08810066bc5f493bb8bc286/ios/chrome/browser/ui/payments/payment_request_payment_app_egtest.mm [modify] https://crrev.com/91bd56ff86e07a34c08810066bc5f493bb8bc286/ios/chrome/browser/ui/payments/payment_request_payment_response_egtest.mm [modify] https://crrev.com/91bd56ff86e07a34c08810066bc5f493bb8bc286/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/91bd56ff86e07a34c08810066bc5f493bb8bc286/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/91bd56ff86e07a34c08810066bc5f493bb8bc286/ios/chrome/test/earl_grey/chrome_matchers.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/c20a4126d689caff7e126880337c71c015e0cf81 commit c20a4126d689caff7e126880337c71c015e0cf81 Author: Menglu Huang <huangml@google.com> Date: Thu Aug 24 21:20:46 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cee1e89bfe964ba4f9be01fc023942ef2879875f commit cee1e89bfe964ba4f9be01fc023942ef2879875f Author: Menglu Huang <huangml@chromium.org> Date: Wed Sep 06 19:21:29 2017 Remove view controllers dependency of settings tests Bug: 750372 Change-Id: I50e8fa524ef65adc3bedf88c1eaa0ad59d784d16 Reviewed-on: https://chromium-review.googlesource.com/642113 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Mike Baxley <baxley@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Menglu Huang <huangml@chromium.org> Cr-Commit-Position: refs/heads/master@{#500037} [modify] https://crrev.com/cee1e89bfe964ba4f9be01fc023942ef2879875f/ios/chrome/browser/ui/settings/accounts_collection_egtest.mm [modify] https://crrev.com/cee1e89bfe964ba4f9be01fc023942ef2879875f/ios/chrome/browser/ui/settings/block_popups_egtest.mm [modify] https://crrev.com/cee1e89bfe964ba4f9be01fc023942ef2879875f/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm [modify] https://crrev.com/cee1e89bfe964ba4f9be01fc023942ef2879875f/ios/chrome/browser/ui/settings/settings_egtest.mm [modify] https://crrev.com/cee1e89bfe964ba4f9be01fc023942ef2879875f/ios/chrome/browser/ui/settings/translate_ui_egtest.mm [modify] https://crrev.com/cee1e89bfe964ba4f9be01fc023942ef2879875f/ios/chrome/test/app/BUILD.gn [add] https://crrev.com/cee1e89bfe964ba4f9be01fc023942ef2879875f/ios/chrome/test/app/password_test_util.h [add] https://crrev.com/cee1e89bfe964ba4f9be01fc023942ef2879875f/ios/chrome/test/app/password_test_util.mm [modify] https://crrev.com/cee1e89bfe964ba4f9be01fc023942ef2879875f/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm [modify] https://crrev.com/cee1e89bfe964ba4f9be01fc023942ef2879875f/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/cee1e89bfe964ba4f9be01fc023942ef2879875f/ios/chrome/test/earl_grey/chrome_matchers.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/851b179e97133fb42ce31b4dbdd4d3cdf3e45697 commit 851b179e97133fb42ce31b4dbdd4d3cdf3e45697 Author: Menglu Huang <huangml@chromium.org> Date: Wed Oct 04 01:07:15 2017 Remove view controller dependency on content suggestion tests Bug: 750372 Change-Id: I52dcb1ce81f3d7ddc85c207e2bce73d0b55460dc Reviewed-on: https://chromium-review.googlesource.com/676693 Reviewed-by: Mike Baxley <baxley@chromium.org> Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Menglu Huang <huangml@chromium.org> Cr-Commit-Position: refs/heads/master@{#506264} [modify] https://crrev.com/851b179e97133fb42ce31b4dbdd4d3cdf3e45697/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm [modify] https://crrev.com/851b179e97133fb42ce31b4dbdd4d3cdf3e45697/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm [modify] https://crrev.com/851b179e97133fb42ce31b4dbdd4d3cdf3e45697/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/851b179e97133fb42ce31b4dbdd4d3cdf3e45697/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/851b179e97133fb42ce31b4dbdd4d3cdf3e45697/ios/chrome/test/earl_grey/chrome_matchers.mm [modify] https://crrev.com/851b179e97133fb42ce31b4dbdd4d3cdf3e45697/ios/showcase/content_suggestions/sc_content_suggestions_egtest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/763224f45c2f9ec9035a778d3495822f1c241ad4 commit 763224f45c2f9ec9035a778d3495822f1c241ad4 Author: Menglu Huang <huangml@chromium.org> Date: Thu Nov 02 22:20:08 2017 Remove view controller dependencies on ios_showcase_egtests Bug: 750372 Change-Id: I23e2cd56ffcfd95dddc5cb88ce7e97404bbf9bf9 Reviewed-on: https://chromium-review.googlesource.com/656605 Reviewed-by: Mike Baxley <baxley@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Menglu Huang <huangml@chromium.org> Cr-Commit-Position: refs/heads/master@{#513617} [modify] https://crrev.com/763224f45c2f9ec9035a778d3495822f1c241ad4/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/763224f45c2f9ec9035a778d3495822f1c241ad4/ios/chrome/test/earl_grey/chrome_matchers.mm [modify] https://crrev.com/763224f45c2f9ec9035a778d3495822f1c241ad4/ios/showcase/payments/sc_payments_editor_egtest.mm [modify] https://crrev.com/763224f45c2f9ec9035a778d3495822f1c241ad4/ios/showcase/payments/sc_payments_picker_egtest.mm [modify] https://crrev.com/763224f45c2f9ec9035a778d3495822f1c241ad4/ios/showcase/payments/sc_payments_selector_egtest.mm
Comment 1 by huangml@chromium.org
, Jul 28 2017