ObserverListThreadSafeTest.CrossThreadObserver still flaking |
||||
Issue descriptionPreviously https://bugs.chromium.org/p/chromium/issues/detail?id=735603 where it was crashing. Now it appears to be timing out, presumably hanging. One example is https://luci-milo.appspot.com/buildbot/chromium.fyi/Fuchsia/7622 . I can't repro locally on Fuchsia QEMU or Linux ASAN. I tried "stare at the code for a while" but I can't come up with a compelling explanation for how this is happening, so filing a bug for ongoing tracking. I'm sort of squinting at the Quit() call https://cs.chromium.org/chromium/src/base/observer_list_unittest.cc?l=160 thinking maybe it can get lost somehow so the thread never quits, but I also can't see any way that could happen, so that might be off-base.
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9759fff7fc48f5d70e0555d51a54540536cf9cc7 commit 9759fff7fc48f5d70e0555d51a54540536cf9cc7 Author: Scott Graham <scottmg@chromium.org> Date: Wed Aug 02 01:53:03 2017 fuchsia: Filter out some known-flake tests in base_unittests Bug: 738275, 735701 , 750370 , 750756 Change-Id: Ibaa143616ce60ae6d94854f9cadc8daf2d84a37c Reviewed-on: https://chromium-review.googlesource.com/596914 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491200} [modify] https://crrev.com/9759fff7fc48f5d70e0555d51a54540536cf9cc7/testing/buildbot/filters/fuchsia.base_unittests.filter
,
Aug 10 2017
Happened again at https://build.chromium.org/p/chromium.fyi/builders/Fuchsia/builds/8604 and probably https://build.chromium.org/p/chromium.fyi/builders/Fuchsia/builds/8631. I also had it happen once locally, but it did "correctly" get terminated, whereas on the bots it's dragging on forever. Seems to either correlate with re-enabling some base_unittests that were filtered, or with the roll of the Fuchsia SDK at https://chromium-review.googlesource.com/c/609392.
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1d6b4b016198475f3d8819ea673b48f5c3a4d8d commit a1d6b4b016198475f3d8819ea673b48f5c3a4d8d Author: Scott Graham <scottmg@chromium.org> Date: Fri Aug 11 17:31:11 2017 fuchsia: log extra process info when test child process hangs One suspicion is that the child process is transitioning to "DYING" but not making it to "DEAD" and so not raising a TERMINATED signal, so the parent process never lets go. Seeing the "exited" bool should tell us if this is the case (but might as well print all the fields in case they're useful.) Ref: https://fuchsia.googlesource.com/magenta/+/HEAD/docs/syscalls/object_get_info.md Bug: 750370 , 738275 Change-Id: I4371ef6784f7cecbab483a9be10f18b0671e54f2 Reviewed-on: https://chromium-review.googlesource.com/611382 Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#493784} [modify] https://crrev.com/a1d6b4b016198475f3d8819ea673b48f5c3a4d8d/base/test/launcher/test_launcher.cc
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42c014d0916cb84be9420e0f3542a0112bc7b797 commit 42c014d0916cb84be9420e0f3542a0112bc7b797 Author: Wez <wez@chromium.org> Date: Thu Jun 21 11:36:14 2018 Remove extra Fuchsia-specific logging from Process and TestLauncher. The issues that this logging was introduced to diagnose are understood and/or resolved, so it can be removed. Also clean up some OS_POSIX && !OS_FUCHSIA preprocessor conditionals, and migrate TestLauncher to use the zx::job container from the SDK. Bug: 755282 , 750370 , 738275, 706592 Change-Id: Iedfaa62684a0b6e8524a456766186b4122e98ae0 Reviewed-on: https://chromium-review.googlesource.com/1108483 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#569219} [modify] https://crrev.com/42c014d0916cb84be9420e0f3542a0112bc7b797/base/process/process_fuchsia.cc [modify] https://crrev.com/42c014d0916cb84be9420e0f3542a0112bc7b797/base/test/BUILD.gn [modify] https://crrev.com/42c014d0916cb84be9420e0f3542a0112bc7b797/base/test/launcher/test_launcher.cc
,
Sep 11
,
Jan 19
(4 days ago)
,
Jan 21
(2 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c114317110c46d1ee35db54df79f2bcb9c5c2ffb commit c114317110c46d1ee35db54df79f2bcb9c5c2ffb Author: Wez <wez@chromium.org> Date: Mon Jan 21 18:05:41 2019 [Fuchsia] Re-enable ObserverListThreadSafeTest.CrossThreadObserver test. Bug: 750370 , 738275 Change-Id: Ibe757df500695ea1d5e6a90c6ccdce3467af80ec Reviewed-on: https://chromium-review.googlesource.com/c/1422787 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#624620} [modify] https://crrev.com/c114317110c46d1ee35db54df79f2bcb9c5c2ffb/base/observer_list_threadsafe_unittest.cc
,
Jan 21
(2 days ago)
|
||||
►
Sign in to add a comment |
||||
Comment 1 by scottmg@chromium.org
, Jul 28 2017