New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750369 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MD Extensions: display policy indicator in detail view.

Project Member Reported by scottchen@chromium.org, Jul 28 2017

Issue description

According to spec, if an extension is controlled by policy, there should be an icon next to the enable-toggle in the detail-view.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb27676f22708c3998fdf42895f7cdb7c346f2f4

commit fb27676f22708c3998fdf42895f7cdb7c346f2f4
Author: Scott Chen <scottchen@chromium.org>
Date: Tue Aug 15 00:25:27 2017

WebUI: extract duplication in cr-x-indicators to new component.

This CL creates a <cr-tooltip-icon> that encapsulates the idea of "an icon that
shows a tooltip on mouseover", and use it to replace duplicated boilerplate html code within cr_elements/policy/cr-x-indicators.

Bug:  750369 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8ce05867ff5ecdde27cbc7b3abfd7bd514859165
Reviewed-on: https://chromium-review.googlesource.com/609366
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494263}
[modify] https://crrev.com/fb27676f22708c3998fdf42895f7cdb7c346f2f4/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/fb27676f22708c3998fdf42895f7cdb7c346f2f4/chrome/test/data/webui/cr_elements/cr_policy_indicator_tests.js
[modify] https://crrev.com/fb27676f22708c3998fdf42895f7cdb7c346f2f4/chrome/test/data/webui/cr_elements/cr_policy_network_indicator_tests.js
[modify] https://crrev.com/fb27676f22708c3998fdf42895f7cdb7c346f2f4/chrome/test/data/webui/cr_elements/cr_policy_pref_indicator_tests.js
[modify] https://crrev.com/fb27676f22708c3998fdf42895f7cdb7c346f2f4/ui/webui/resources/cr_elements/policy/compiled_resources2.gyp
[modify] https://crrev.com/fb27676f22708c3998fdf42895f7cdb7c346f2f4/ui/webui/resources/cr_elements/policy/cr_policy_indicator.html
[modify] https://crrev.com/fb27676f22708c3998fdf42895f7cdb7c346f2f4/ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html
[modify] https://crrev.com/fb27676f22708c3998fdf42895f7cdb7c346f2f4/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html
[delete] https://crrev.com/50d047a7d5a364611e12f5b2fcc20b6052634a58/ui/webui/resources/cr_elements/policy/cr_policy_vars_css.html
[add] https://crrev.com/fb27676f22708c3998fdf42895f7cdb7c346f2f4/ui/webui/resources/cr_elements/policy/cr_tooltip_icon.html
[add] https://crrev.com/fb27676f22708c3998fdf42895f7cdb7c346f2f4/ui/webui/resources/cr_elements/policy/cr_tooltip_icon.js
[modify] https://crrev.com/fb27676f22708c3998fdf42895f7cdb7c346f2f4/ui/webui/resources/cr_elements_resources.grdp

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70f1c65145c53a0e5564455024ca8d95d557bd23

commit 70f1c65145c53a0e5564455024ca8d95d557bd23
Author: Scott Chen <scottchen@chromium.org>
Date: Tue Aug 15 22:48:51 2017

MD Extensions: add controlled indicator in detail view.

Bug:  750369 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I347e79e0d34912226fe9adcc60f76b65fd3a6dcb
Reviewed-on: https://chromium-review.googlesource.com/609402
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494581}
[modify] https://crrev.com/70f1c65145c53a0e5564455024ca8d95d557bd23/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/70f1c65145c53a0e5564455024ca8d95d557bd23/chrome/browser/resources/md_extensions/detail_view.js
[modify] https://crrev.com/70f1c65145c53a0e5564455024ca8d95d557bd23/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
[modify] https://crrev.com/70f1c65145c53a0e5564455024ca8d95d557bd23/chrome/test/data/webui/extensions/extension_detail_view_test.js
[modify] https://crrev.com/70f1c65145c53a0e5564455024ca8d95d557bd23/chrome/test/data/webui/extensions/extension_pack_dialog_test.js
[modify] https://crrev.com/70f1c65145c53a0e5564455024ca8d95d557bd23/chrome/test/data/webui/extensions/extension_test_util.js
[modify] https://crrev.com/70f1c65145c53a0e5564455024ca8d95d557bd23/ui/webui/resources/cr_elements/icons.html

Status: Fixed (was: Started)

Sign in to add a comment