New issue
Advanced search Search tips

Issue 750366 link

Starred by 1 user
Status: Fixed
Owner:
yuweih@chromium.org
Closed: Jul 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[CRD iOS] Telemetry logger doesn't have the access token when sending the first log

Project Member Reported by yuweih@chromium.org, Jul 28 2017 
Currently the access token is not set for the first log. The logger will only ask for the token when it fails to send the log due to denied permissions. This will bump up our error rate statistics  as it happened to our Android client.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c009a74388dd45218c73c149579b5bf48b64a44

commit 7c009a74388dd45218c73c149579b5bf48b64a44
Author: Yuwei Huang <yuweih@chromium.org>
Date: Mon Jul 31 18:59:46 2017

[CRD iOS] Feed logger immediately with access token

Previously we don't feed the logger with access token until the logger
fails to send a log due to denied permissions, which will pollute our
error rate statistics.

This CL makes the app set the logger's access token immediately after the
user logs in or switches account.

Bug:  750366 
Change-Id: I6898efd73339b2207d954422bcf2410eb0efa4f5
Reviewed-on: https://chromium-review.googlesource.com/591510
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490788}
[modify] https://crrev.com/7c009a74388dd45218c73c149579b5bf48b64a44/remoting/ios/facade/ios_client_runtime_delegate.h
[modify] https://crrev.com/7c009a74388dd45218c73c149579b5bf48b64a44/remoting/ios/facade/ios_client_runtime_delegate.mm
[modify] https://crrev.com/7c009a74388dd45218c73c149579b5bf48b64a44/remoting/ios/facade/remoting_service.mm

Comment 2 by yuweih@chromium.org, Jul 31 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment