Don't connect to SsbService on Low-End devices |
||||||
Issue description
We currently see a connection established to SsbService for low-end devices. However, the data we need from SsbService is not needed for low-end because icing functionality is disabled. Connecting to SsbService brings it to foreground and increases peak memory during startup.
com.google.android.googlequicksearchbox:search/u0a23 <- com.android.chrome/u0a50
via com.google.android.googlequicksearchbox/com.google.android.ssb.service.SsbService
+9s210ms (2 times) TOP =+9s210ms*
Currently active: +9s210ms
,
Aug 2 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/0504da708e843bf4ca0a1fff911ee2f39e057efd commit 0504da708e843bf4ca0a1fff911ee2f39e057efd Author: Maria Khomenko <mariakhomenko@google.com> Date: Wed Aug 02 17:44:32 2017
,
Aug 3 2017
Requesting merge for this change because M-61 is the Android Go release and this significantly helps with peak memory consumption on startup because with this logic we avoid binding to SSB -- which we don't need to do on low-end devices as icing is disabled.
,
Aug 4 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 4 2017
Approved for M61 branch 3163.
,
Aug 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b65fee7fd540cfebe10f6332b295f6ea7fdb2d01 commit b65fee7fd540cfebe10f6332b295f6ea7fdb2d01 Author: Maria Khomenko <mariakhomenko@chromium.org> Date: Mon Aug 07 18:01:02 2017 Don't bind to SsbService on low-end devices. We only use SsbService to pass signed in account data for Icing. On low-end devices, Icing is disabled, so we don't need this data. BUG= 750365 TBR=mariakhomenko@chromium.org (cherry picked from commit 921be3d90061bb40d9f54e015cc7e54843e152ad) Change-Id: I00d9faa3a592de4b5471ec5226508facbd48c637 Reviewed-on: https://chromium-review.googlesource.com/592487 Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by: Benoit L <lizeb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#491105} Reviewed-on: https://chromium-review.googlesource.com/604048 Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#359} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/b65fee7fd540cfebe10f6332b295f6ea7fdb2d01/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/b65fee7fd540cfebe10f6332b295f6ea7fdb2d01/chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAAccountChangeListener.java
,
Aug 7 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/3f806587db3a8cf39b2c2b6bafc9218ee9ba65e3 commit 3f806587db3a8cf39b2c2b6bafc9218ee9ba65e3 Author: Maria Khomenko <mariakhomenko@google.com> Date: Mon Aug 07 18:10:07 2017
,
Aug 7 2017
,
Aug 9 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/50140377c6aebb9e2484d879b4ee430e374c2c25 commit 50140377c6aebb9e2484d879b4ee430e374c2c25 Author: Benoît Lizé <lizeb@google.com> Date: Wed Aug 09 19:23:48 2017
,
Aug 9 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/dd83806742fac5c7bcc6bf9347d77480cb0a364f commit dd83806742fac5c7bcc6bf9347d77480cb0a364f Author: Benoît Lizé <lizeb@google.com> Date: Wed Aug 09 22:59:49 2017 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Aug 1 2017