New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750364 link

Starred by 0 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 767895



Sign in to add a comment

swarmbucket performance page fails with error

Project Member Reported by robert...@chromium.org, Jul 28 2017

Issue description

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fe69f10cf548e828012699b2f2a0f1dad9860bac

commit fe69f10cf548e828012699b2f2a0f1dad9860bac
Author: Roberto Carrillo <robertocn@google.com>
Date: Mon Jul 31 18:53:56 2017

[Findit] Allow for tryjobs with no buildbucket response.

In swarmbucket_performance, the way we look for job that are run using
swarmbucket is by querying for all tryjobs in a date range and then
examining their .last_buildbucket_response field. However, this might
not be set for all jobs.

This change takes this into account to avoid an App Engine error.

R=chanli,lijeffrey,wylieb,stgao
BUG=750364

Change-Id: I4883c326848299266330a616fe1a475df679e31e
Reviewed-on: https://chromium-review.googlesource.com/594359
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/fe69f10cf548e828012699b2f2a0f1dad9860bac/appengine/findit/handlers/test/swarmbucket_performance_test.py
[modify] https://crrev.com/fe69f10cf548e828012699b2f2a0f1dad9860bac/appengine/findit/handlers/swarmbucket_performance.py

Status: Assigned (was: Started)
Blocking: 767895
Labels: -Pri-1 Pri-2

Sign in to add a comment