New issue
Advanced search Search tips

Issue 750360 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

some upstart jobs aren't marked as tasks even though they are tasks

Project Member Reported by semenzato@chromium.org, Jul 28 2017

Issue description

Upstart jobs that don't start daemons should all be marked with the "task" keyword.  However, this needs to be done carefully because marking job X as task changes the behavior of "start on started X" in the following way: for a task, "started X" fires when the process started by exec or script ends.  For a non-task, "started X" fires when that process has started.  Getting this wrong can create race conditions.

Some jobs that should probably be marked as tasks are: swap.conf, crash-boot-collect.conf.  There are many others, and most of them are probably not referenced by other jobs, so it makes no difference whether they are tasks or not.  Still, there could be bugs lurking in there.

OK maybe this is a weenie bug but I have already typed it in, so here it goes.



 
Some relevant discussion is here:

https://chromium-review.googlesource.com/c/590929/

In particular note the pointer to "job lifecycle" in the Upstart docs.

http://upstart.ubuntu.com/cookbook/#job-lifecycle

Owner: curtissa@google.com
Alexander might take a look.  Very tentative though.
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 12 2018

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
The assigned owner "curtissa@google.com" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: OS>Systems>Security
Is this still required?
Pri 3 sounds like the right priority for it. It'd be nice to mark upstart tasks as such (ex: src/platform2/cryptohome/init/mount-encrypted.conf). But it causes no issues atm, and converting them to tasks may affect performance as described above.

Sign in to add a comment