New issue
Advanced search Search tips

Issue 750347 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Change "chromium_revision" in layout test json results to commit position number only

Project Member Reported by qyears...@chromium.org, Jul 28 2017

Issue description

Currently, the chromium_revision field in the layout test results JSON is a full commit position, including ref and number, e.g. "refs/heads/master{#123}".

Since we always want the commit position number on the main chromium/src master branch, we can change that field to be just a number.

Related place in the code: https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py?l=318

Updating this will require updating that location, as well as webkitpy/common/net/layout_test_results.py and any other code that uses this field, including the results viewer page.
 

Comment 1 by foolip@chromium.org, Dec 18 2017

Labels: -Pri-2 Pri-3
Project Member

Comment 2 by sheriffbot@chromium.org, Dec 18

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment