Support secure EmbeddedTestServer on Android |
|||||||
Issue descriptionConnectionInfoPopup is viewable for HTTPS sites, so it would be best if we can test it with HTTPS test server for e.g. https://chromium-review.googlesource.com/c/575835/ jbudorick@, could you triage?
,
Jul 29 2017
,
Jul 29 2017
+Menglu who did this for iOS
,
Jul 29 2017
,
Aug 3 2017
I can take this, I need it for a few things. shenghuazhang@, please let me know if you've already started working on it.
,
Aug 3 2017
,
Aug 3 2017
No I've not started on it yet, feel free to take it :)
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92 commit 8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92 Author: Emily Stark <estark@google.com> Date: Wed Aug 09 22:58:22 2017 Expose EmbeddedTestServer's HTTPS abilities to Java This change allows Java users of EmbeddedTestServer to configure the server to run HTTPS, using the same ServerCertificate options that are available to C++ users. This will allow us to write integration tests for security UI and will allow the replacement of some TestWebServer uses. One complication is that, for Android tests, EmbeddedTestServer runs in a separate process, so its method of installing test root certs doesn't work out of the box. To make this work, I've made the test process server ask the out-of-process server for its root certificate, which it then installs in a test root store. As a first user of this functionality, I've re-enabled an old flaky omnibox test. The test originally was hitting a real external url (google.com) to test HTTPS, which I assume was the source of the flakiness. I've rewritten it to hit an EmbeddedTestServer HTTPS URL, and updated it for recent UI changes. Bug: 750343 , 736867 Change-Id: I2f98924d6b9998bc75ec2f74bd8ad5582942cb28 Reviewed-on: https://chromium-review.googlesource.com/598510 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#493168} [modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java [modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java [modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/net/android/BUILD.gn [modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java [modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServerImpl.java [modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/net/test/android/javatests/src/org/chromium/net/test/IEmbeddedTestServerImpl.aidl [modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/net/test/embedded_test_server/android/embedded_test_server_android.cc [modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/net/test/embedded_test_server/android/embedded_test_server_android.h [modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/net/test/embedded_test_server/embedded_test_server.cc [modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/net/test/embedded_test_server/embedded_test_server.h
,
Aug 9 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jbudorick@chromium.org
, Jul 29 2017Owner: ----
Status: Available (was: Assigned)