New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750343 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Support secure EmbeddedTestServer on Android

Project Member Reported by lgar...@chromium.org, Jul 28 2017

Issue description

ConnectionInfoPopup is viewable for HTTPS sites, so it would be best if we can test it with HTTPS test server for e.g. https://chromium-review.googlesource.com/c/575835/


jbudorick@, could you triage?
 
Cc: baxley@chromium.org jbudorick@chromium.org yolandyan@chromium.org shenghua...@chromium.org
Owner: ----
Status: Available (was: Assigned)
+some relevant folks here
Labels: -Type-Bug OS-Android Type-Feature

Comment 3 by baxley@chromium.org, Jul 29 2017

Cc: huangml@chromium.org
+Menglu who did this for iOS
Cc: -shenghua...@chromium.org
Owner: shenghua...@chromium.org
Status: Assigned (was: Available)
Cc: shenghua...@chromium.org
Owner: est...@chromium.org
I can take this, I need it for a few things. shenghuazhang@, please let me know if you've already started working on it.
Status: Started (was: Assigned)
No I've not started on it yet, feel free to take it :)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92

commit 8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92
Author: Emily Stark <estark@google.com>
Date: Wed Aug 09 22:58:22 2017

Expose EmbeddedTestServer's HTTPS abilities to Java

This change allows Java users of EmbeddedTestServer to configure the server to
run HTTPS, using the same ServerCertificate options that are available to C++
users. This will allow us to write integration tests for security UI and will
allow the replacement of some TestWebServer uses.

One complication is that, for Android tests, EmbeddedTestServer runs in a
separate process, so its method of installing test root certs doesn't
work out of the box. To make this work, I've made the test process
server ask the out-of-process server for its root certificate, which it
then installs in a test root store.

As a first user of this functionality, I've re-enabled an old flaky omnibox
test. The test originally was hitting a real external url (google.com) to test
HTTPS, which I assume was the source of the flakiness. I've rewritten it to hit
an EmbeddedTestServer HTTPS URL, and updated it for recent UI changes.

Bug:  750343 , 736867
Change-Id: I2f98924d6b9998bc75ec2f74bd8ad5582942cb28
Reviewed-on: https://chromium-review.googlesource.com/598510
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493168}
[modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java
[modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java
[modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/net/android/BUILD.gn
[modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java
[modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServerImpl.java
[modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/net/test/android/javatests/src/org/chromium/net/test/IEmbeddedTestServerImpl.aidl
[modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/net/test/embedded_test_server/android/embedded_test_server_android.cc
[modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/net/test/embedded_test_server/android/embedded_test_server_android.h
[modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/net/test/embedded_test_server/embedded_test_server.cc
[modify] https://crrev.com/8f0f8f4ae8d1a4f357dc39e4d3861e54dffe4d92/net/test/embedded_test_server/embedded_test_server.h

Labels: M-62
Status: Fixed (was: Started)

Sign in to add a comment