New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 750341 link

Starred by 1 user
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
rdevlin....@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MD Extension: remove button should be hidden for non-removable extensions.

Project Member Reported by scottchen@chromium.org, Jul 28 2017 
remove button should be hidden for non-removable extensions.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8df8e92d6fac5fe8a02740fef7de17c9d2f50bce

commit 8df8e92d6fac5fe8a02740fef7de17c9d2f50bce
Author: Scott Chen <scottchen@chromium.org>
Date: Wed Aug 02 04:31:40 2017

MD Extensions: hide remove button when extension is controlled

Bug:  750341 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I26a75ee076b3a9a5d22e18b71e0a35105ee7b552
Reviewed-on: https://chromium-review.googlesource.com/592309
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491267}
[modify] https://crrev.com/8df8e92d6fac5fe8a02740fef7de17c9d2f50bce/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/8df8e92d6fac5fe8a02740fef7de17c9d2f50bce/chrome/browser/resources/md_extensions/detail_view.js
[modify] https://crrev.com/8df8e92d6fac5fe8a02740fef7de17c9d2f50bce/chrome/browser/resources/md_extensions/item.html
[modify] https://crrev.com/8df8e92d6fac5fe8a02740fef7de17c9d2f50bce/chrome/browser/resources/md_extensions/item.js
[modify] https://crrev.com/8df8e92d6fac5fe8a02740fef7de17c9d2f50bce/chrome/browser/resources/md_extensions/item_util.js
[modify] https://crrev.com/8df8e92d6fac5fe8a02740fef7de17c9d2f50bce/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
[modify] https://crrev.com/8df8e92d6fac5fe8a02740fef7de17c9d2f50bce/chrome/test/data/webui/extensions/extension_item_test.js

Comment 2 by scottchen@chromium.org, Aug 2 2017

Status: Fixed (was: Started)
►

Sign in to add a comment