New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750323 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 749868



Sign in to add a comment

telemetry downloaded executables don't exist for chromeos

Project Member Reported by achuith@chromium.org, Jul 28 2017

Issue description

There's a binary_dependencies.json with binary executables downloaded on demand by telemetry based on platform/arch:
https://cs.chromium.org/chromium/src/tools/perf/chrome_telemetry_build/binary_dependencies.json

This is missing entries for chromeos, which could perhaps be fixed by using linux binaries instead, which ought to work.

It's possible there's a more fundamental problem with running downloaded executables, but maybe this this works on chromeos test images.

There are failing tests as a result of this problem.
 
Cc: afakhry@chromium.org
Components: Tests>Telemetry
Blocking: 749868
Sample stack of failing test.

[1/1] telemetry.internal.util.webpagereplay_go_server_unittest.WebPageReplayGoServerTest.testSmokeStartingWebPageReplayGoServer failed unexpectedly 0.0009s:
  Traceback (most recent call last):
    File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/util/webpagereplay_go_server_unittest.py", line 21, in setUp
      py_utils.GetHostOsName())
    File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/util/binary_manager.py", line 66, in FetchPath
      return _binary_manager.FetchPath(binary_name, os_name, arch, os_version)
    File "/usr/local/telemetry/src/third_party/catapult/common/py_utils/py_utils/binary_manager.py", line 38, in FetchPath
      os_version)
    File "/usr/local/telemetry/src/third_party/catapult/common/py_utils/py_utils/binary_manager.py", line 60, in _WrapDependencyManagerFunction
      return function(binary_name, platform)
    File "/usr/local/telemetry/src/third_party/catapult/dependency_manager/dependency_manager/manager.py", line 130, in FetchPath
      path, _ = self.FetchPathWithVersion(dependency, platform)
    File "/usr/local/telemetry/src/third_party/catapult/dependency_manager/dependency_manager/manager.py", line 89, in FetchPathWithVersion
      raise exceptions.NoPathFoundError(dependency, platform)
  NoPathFoundError: No file could be found locally, and no file to download from cloud storage for example_domain_wpr_go_archive on platform chromeos_x86_64

Cc: xunji...@chromium.org
Owner: achuith@chromium.org
Status: Assigned (was: Untriaged)
Summary: telemetry downloaded executables don't exist for chromeos (was: telemetry downloaded executables don't work on chromeos)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bff6dcd05338c0b6e2ca2e0296461a4b745a16ff

commit bff6dcd05338c0b6e2ca2e0296461a4b745a16ff
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Wed Aug 02 11:39:42 2017

Roll src/third_party/catapult/ 95988f787..0327c967e (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/95988f787423..0327c967ed7f

$ git log 95988f787..0327c967e --date=short --no-merges --format='%ad %ae %s'
2017-08-02 achuith Use linux binaries on chromeos.

Created with:
  roll-dep src/third_party/catapult
BUG=750323


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I501c4bfc339b126254ac10f685238e2adece9462
Reviewed-on: https://chromium-review.googlesource.com/597727
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491336}
[modify] https://crrev.com/bff6dcd05338c0b6e2ca2e0296461a4b745a16ff/DEPS

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/720c8ddf5c5f442062ec595c02e644e631f6ed33

commit 720c8ddf5c5f442062ec595c02e644e631f6ed33
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Sat Aug 05 06:08:48 2017

Roll src/third_party/catapult/ 0fb50e3f8..33a9271eb (4 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0fb50e3f84ef..33a9271eb3cf

$ git log 0fb50e3f8..33a9271eb --date=short --no-merges --format='%ad %ae %s'
2017-08-04 achuith Disable testSmokeStartingWebPageReplayGoServer on chromeos.
2017-08-04 nednguyen Add markdown version of run_telemetry_tests documentation
2017-08-04 charliea Catch all BattOr shell graceful shutdown failures
2017-08-04 xunjieli [wpr-go] Update README

Created with:
  roll-dep src/third_party/catapult
BUG=750323, 752270 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ia77bd543b748caad646d357f7cedc4724604fe6a
Reviewed-on: https://chromium-review.googlesource.com/602745
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492231}
[modify] https://crrev.com/720c8ddf5c5f442062ec595c02e644e631f6ed33/DEPS

Components: Test>Telemetry
Components: -Tests>Telemetry

Sign in to add a comment