New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750322 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Blank row appears in "Mobile Data" section when Tether connection fails

Project Member Reported by lesliewatkins@chromium.org, Jul 28 2017

Issue description

Chrome Version: 62.0.3170.0

What steps will reproduce the problem?
(1) Enable Tethering on phone and laptop.
(2) Attempt to connect to Tether network.
(3) Network configuration fails.

What is the expected result?
Nothing appears in 'Mobile Data' section of system tray.

What happens instead?
A blank row appears in 'Mobile Data' section of system tray.

 
log.txt
7.4 KB View Download
Screenshot 2017-07-28 at 1.12.33 PM.png
867 KB View Download
Labels: M-61
Status: Available (was: Untriaged)
What do you mean by "(3) Network configuration fails."? Are you just saying that the connection attempt failed?
Also, can you attach the ProximityAuth logs?
The logs attached show:

[28316:28316:0728/115616.470749:ERROR:network_connect.cc(164)] NOTREACHED() hit.

...but I suspect that that's an unrelated issue to the UI issue.
Yes, "Network configuration fails" = "Instant tethering connection fails"

I don't have the ProximityAuth logs and this is tricky to reproduce, but I'll be ready next time it happens!
Owner: lesliewatkins@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
The expected result above is incorrect-- the network should appear under the Mobile Data section, but be disconnected.
Screenshot 2017-08-09 at 11.32.59 AM.png
871 KB View Download
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82d95b25401b8b33f3f2df41948fb4c63dd7df32

commit 82d95b25401b8b33f3f2df41948fb4c63dd7df32
Author: Leslie Watkins <lesliewatkins@chromium.org>
Date: Thu Aug 10 17:31:34 2017

Force Layout every time a HoverHightlightView is updated.

When an item in the system tray network list goes from connecting to disconnected without a Layout 
of the parent view being triggered, it isn't rendered correctly. This is probably due to the fact 
that the "connecting" view has a sub_text_label and the "disconnected" view does not. The problem 
is solved when a Layout of the view is performed every time UpdateViewForNetwork is called.

Bug:  750322 , 672263
Change-Id: I785b2874db583a6d28aaeefed86d813141f6e79a
Reviewed-on: https://chromium-review.googlesource.com/609216
Reviewed-by: Terry Anderson <tdanderson@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Leslie Watkins <lesliewatkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493446}
[modify] https://crrev.com/82d95b25401b8b33f3f2df41948fb4c63dd7df32/ash/system/network/network_list.cc

Labels: Merge-Request-61
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 10 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c00f27d3521ccd7eeb1d0a68a6c1d8097baba9fb

commit c00f27d3521ccd7eeb1d0a68a6c1d8097baba9fb
Author: Kyle Horimoto <khorimoto@google.com>
Date: Thu Aug 10 18:13:45 2017

Force Layout every time a HoverHightlightView is updated.

When an item in the system tray network list goes from connecting to disconnected without a Layout
of the parent view being triggered, it isn't rendered correctly. This is probably due to the fact
that the "connecting" view has a sub_text_label and the "disconnected" view does not. The problem
is solved when a Layout of the view is performed every time UpdateViewForNetwork is called.

TBR=lesliewatkins@chromium.org

(cherry picked from commit 82d95b25401b8b33f3f2df41948fb4c63dd7df32)

Bug:  750322 , 672263
Change-Id: I785b2874db583a6d28aaeefed86d813141f6e79a
Reviewed-on: https://chromium-review.googlesource.com/609216
Reviewed-by: Terry Anderson <tdanderson@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Leslie Watkins <lesliewatkins@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493446}
Reviewed-on: https://chromium-review.googlesource.com/610887
Cr-Commit-Position: refs/branch-heads/3163@{#440}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/c00f27d3521ccd7eeb1d0a68a6c1d8097baba9fb/ash/system/network/network_list.cc

Status: Fixed (was: Started)

Comment 15 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment