Presence of dummy state in ax_enums.idl fixes seemingly unrelated input selection test failures |
|||||||||||
Issue descriptionThe following tests fail or pass depending on the position of a dummy StateType in ax_enums.idl. ArcVoiceInteractionArcHomeServiceTest.VoiceInteractionStructureInputSelectionTest org.chromium.content.browser.webcontents.AccessibilitySnapshotTest#testRequestAccessibilitySnapshotInputSelection Clues: - Both failing tests are similar relate to selection in an input field. The text "Hello, World" is garbled - If the dummy state occurs before editable, the tests pass. If the dummy state is not present or comes after editable, the tests fail. - Removal of the dummy state from either idl causes the failure - ASAN build does not produce the failure - Returning AX_STATE_HORIZONTAL instead of AX_STATE_EDITABLE in blink_ax_enum_conversion.cc's AXStateFromBlink() makes the test pass - One test uses AccessibilitySnapshotNode directly, while the other uses VoiceInteractionStructure which says the fields are consistent with VoiceInteractionStructure - Keeping the dummy state in and returning it as an accessibility state causes the failure, even though the dummy state is not referred to anywhere else in the code. See test failures at: https://chromium-review.googlesource.com/c/596931 This command will repro a failure: ninja -C out/linux-debug -j 500 browser_tests && out/linux-debug/browser_tests --gtest_filter="ArcVoiceInteractionArcHomeServiceTest.VoiceInteractionStructureInputSelectionTest" --test-launcher-jobs=1
,
Aug 2 2017
,
Aug 2 2017
,
Aug 2 2017
CC'ing developers of the input selection tests. Anyone have any idea why the presence of a dummy accessibility state is required for these input selection test to pass?! Very odd.
,
Aug 2 2017
,
Aug 2 2017
,
Aug 2 2017
I'm making some progress debugging this.
,
Aug 2 2017
,
Aug 2 2017
,
Aug 2 2017
,
Aug 2 2017
Found the cause and fix. CL Coming soon. Bitfield tests need 1 << enumconstant
,
Aug 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19e8a73f10a1fe3be9a0d0af93c3132945884e41 commit 19e8a73f10a1fe3be9a0d0af93c3132945884e41 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Mon Aug 07 17:09:13 2017 Removing dummy states is causing strange input selection test failures Bug: 750305 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4ed64343583af266fbaa4f087aecbb31583bcd75 Reviewed-on: https://chromium-review.googlesource.com/596931 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#492344} [modify] https://crrev.com/19e8a73f10a1fe3be9a0d0af93c3132945884e41/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service_browsertest.cc [modify] https://crrev.com/19e8a73f10a1fe3be9a0d0af93c3132945884e41/chrome/common/extensions/api/automation.idl [modify] https://crrev.com/19e8a73f10a1fe3be9a0d0af93c3132945884e41/third_party/closure_compiler/externs/automation.js [modify] https://crrev.com/19e8a73f10a1fe3be9a0d0af93c3132945884e41/ui/accessibility/ax_enums.idl [modify] https://crrev.com/19e8a73f10a1fe3be9a0d0af93c3132945884e41/ui/accessibility/platform/ax_snapshot_node_android_platform.cc
,
Aug 7 2017
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by aleventhal@chromium.org
, Jul 28 2017