New issue
Advanced search Search tips

Issue 750293 link

Starred by 2 users
Status: Fixed
Owner:
rogerm@chromium.org
Closed: Aug 2017
Cc:
se...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocked on:
issue 755866


Sign in to add a comment

Don't offer Credit card suggestions for expiration only

Project Member Reported by se...@chromium.org, Jul 28 2017 
For example at https://bugs.chromium.org/p/chromium/issues/entry the estimatedDays field offers a credit card month suggestion.

The proposed solution is to only show suggestions if we detect at least 2 credit card fields and one of them is a cc-number. 

The reason being the our precision and recall on cc-nums are very high.

Comment 1 by se...@chromium.org, Aug 2 2017 


Before, suggestions would be shown for each field predicted as a
credit card field.

Now, we won't show suggestions if there is only one credit card field
in a form with non credit card fields. Won't show suggestions for exp
month or year fields if they are the only field in a form.

Comment 2 by ma...@chromium.org, Aug 3 2017

Cc: se...@chromium.org
Owner: rogerm@chromium.org
Per offline discussion, over to Roger!
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32f74156b54692a441e59352e7ec13af6c90fff3

commit 32f74156b54692a441e59352e7ec13af6c90fff3
Author: Roger McFarlane <rogerm@chromium.org>
Date: Tue Aug 15 15:15:19 2017

[autofill] Rationalize CC field type predictions.

This CL adds heuristic logic to avoid predicting lone credit card
fields in forms.

BUG= 750293 , 715828

Change-Id: Ic6c85f3b6a7aa16cc3fce513b7e26ff022ec852e
Reviewed-on: https://chromium-review.googlesource.com/605968
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494382}
[modify] https://crrev.com/32f74156b54692a441e59352e7ec13af6c90fff3/chrome/browser/autofill/form_structure_browsertest.cc
[add] https://crrev.com/32f74156b54692a441e59352e7ec13af6c90fff3/chrome/test/data/autofill/heuristics/input/147_panera.custhelp.com_app_ask.html
[add] https://crrev.com/32f74156b54692a441e59352e7ec13af6c90fff3/chrome/test/data/autofill/heuristics/output/147_panera.custhelp.com_app_ask.out
[modify] https://crrev.com/32f74156b54692a441e59352e7ec13af6c90fff3/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/32f74156b54692a441e59352e7ec13af6c90fff3/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/32f74156b54692a441e59352e7ec13af6c90fff3/components/autofill/core/browser/autofill_field.cc
[modify] https://crrev.com/32f74156b54692a441e59352e7ec13af6c90fff3/components/autofill/core/browser/autofill_field.h
[modify] https://crrev.com/32f74156b54692a441e59352e7ec13af6c90fff3/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/32f74156b54692a441e59352e7ec13af6c90fff3/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/32f74156b54692a441e59352e7ec13af6c90fff3/components/autofill/core/browser/form_structure_unittest.cc

Comment 4 by rogerm@chromium.org, Aug 16 2017

Blockedon: 755866

Comment 5 by rogerm@chromium.org, Aug 16 2017

Status: Fixed (was: Started)

Comment 6 by zkoch@chromium.org, Aug 17 2017 

Issue 756636 has been merged into this issue.
►

Sign in to add a comment