New issue
Advanced search Search tips

Issue 750282 link

Starred by 1 user
Status: Fixed
Owner:
michae...@chromium.org
Closed: Aug 2017
Cc:
r...@chromium.org
osh...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 2
Type: Bug

Blocking:
issue 675413



Sign in to add a comment

AppShell does not resize contents when window resizes

Project Member Reported by michae...@chromium.org, Jul 28 2017 
AppShell should resize the WebContents when the host window is resized.

Instead, the WebContents remains the same size, even if the host is larger or smaller. The app being displayed will not stretch or shrink as a web page normally would when its frame is resized.

1. ./out/app_shell --load-app=/path/to/app
2. resize window
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38e3aa5ed798338e5bd902553f6f7e61d072d4d9

commit 38e3aa5ed798338e5bd902553f6f7e61d072d4d9
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Fri Aug 04 19:35:28 2017

AppShell: Resize content on window resize

The layout manager should resize child windows when the root window is
resized. Otherwise, the WebContents will not be resized, so the page
will not update and |window.innerHeight| and so forth will reflect the
original size.

Bug:  750282 
Change-Id: I1586de45e7342e5ab4a7f24075dd9dc99756d0f6
Reviewed-on: https://chromium-review.googlesource.com/592609
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492102}
[modify] https://crrev.com/38e3aa5ed798338e5bd902553f6f7e61d072d4d9/extensions/shell/browser/shell_desktop_controller_aura.cc
[modify] https://crrev.com/38e3aa5ed798338e5bd902553f6f7e61d072d4d9/extensions/shell/browser/shell_desktop_controller_aura.h
[modify] https://crrev.com/38e3aa5ed798338e5bd902553f6f7e61d072d4d9/extensions/shell/browser/shell_desktop_controller_aura_unittest.cc

Comment 2 by michae...@chromium.org, Aug 4 2017

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce005aba45e2e62137d9169555eeabf85cfa5a4c

commit ce005aba45e2e62137d9169555eeabf85cfa5a4c
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Mon Aug 07 23:26:57 2017

AppShell: Simplify DesktopController interface

Don't call DesktopController::RemoveAppWindow manually from
ShellNativeAppWindow. Instead, ShellDesktopControllerAura should observe
the AppWindowRegistry directly when it sees a new BrowserContext.

Some other minor niceties like converting the vector to a list.

Bug:  750282 
Change-Id: I4d8021fa469e049971abf9c84f49008a17754244
Reviewed-on: https://chromium-review.googlesource.com/596686
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492442}
[modify] https://crrev.com/ce005aba45e2e62137d9169555eeabf85cfa5a4c/extensions/browser/app_window/app_window_registry.cc
[modify] https://crrev.com/ce005aba45e2e62137d9169555eeabf85cfa5a4c/extensions/browser/app_window/app_window_registry.h
[modify] https://crrev.com/ce005aba45e2e62137d9169555eeabf85cfa5a4c/extensions/browser/app_window/test_app_window_contents.cc
[modify] https://crrev.com/ce005aba45e2e62137d9169555eeabf85cfa5a4c/extensions/browser/app_window/test_app_window_contents.h
[modify] https://crrev.com/ce005aba45e2e62137d9169555eeabf85cfa5a4c/extensions/shell/browser/desktop_controller.h
[modify] https://crrev.com/ce005aba45e2e62137d9169555eeabf85cfa5a4c/extensions/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/ce005aba45e2e62137d9169555eeabf85cfa5a4c/extensions/shell/browser/shell_browser_main_parts.h
[modify] https://crrev.com/ce005aba45e2e62137d9169555eeabf85cfa5a4c/extensions/shell/browser/shell_desktop_controller_aura.cc
[modify] https://crrev.com/ce005aba45e2e62137d9169555eeabf85cfa5a4c/extensions/shell/browser/shell_desktop_controller_aura.h
[modify] https://crrev.com/ce005aba45e2e62137d9169555eeabf85cfa5a4c/extensions/shell/browser/shell_desktop_controller_aura_unittest.cc
[modify] https://crrev.com/ce005aba45e2e62137d9169555eeabf85cfa5a4c/extensions/shell/browser/shell_desktop_controller_mac.h
[modify] https://crrev.com/ce005aba45e2e62137d9169555eeabf85cfa5a4c/extensions/shell/browser/shell_desktop_controller_mac.mm
[modify] https://crrev.com/ce005aba45e2e62137d9169555eeabf85cfa5a4c/extensions/shell/browser/shell_native_app_window.cc
[modify] https://crrev.com/ce005aba45e2e62137d9169555eeabf85cfa5a4c/extensions/shell/browser/shell_native_app_window_aura_unittest.cc
►

Sign in to add a comment