New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750272 link

Starred by 24 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Volume up/down with hardware buttons should take Chromebook's orientation in consideration

Project Member Reported by drcrash@google.com, Jul 28 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Steps to reproduce the problem:
1.  Take a convertible Chromebook. The Samsung Pro is a great example because it has a big Samsung logo under the screen.
2. Flip it in tablet mode. In our case, keep the Samsung at the bottom of the screen.
3. Use the side hardware volume buttons to change volume.

What is the expected behavior?
The half of the volume button on top should raise the volume. The half at the bottom should lower it.

What went wrong?
Pushing up gets the volume down. Pushing down gets the volume up.

My guess is that the hardware buttons may just generate key events? But even in this case, since we know we're in tablet mode and the normal keyboard is neutralized, we should be able to look at the screen orientation and do the right thing from an ergonomic perspective, which is: the upper side of the button turns the volume up, and the lower side lowers it.

Did this work before? N/A 

Chrome version: 59.0.3071.115  Channel: n/a
OS Version: OS X 10.12.6
Flash Version:
 
Cc: drcrash@chromium.org

Comment 2 by rsesek@chromium.org, Jul 28 2017

Labels: -OS-Mac OS-Chrome

Comment 3 by xiy...@chromium.org, Aug 11 2017

Components: Internals>Input
I'm glad to see this in the bug tracker.  Most people flip convertibles into tablet mode and don't re-orient the screen.  So, the screen will likely keep the orientation it was in while in laptop mode.

With that general behavior, the volume buttons are almost always upside down for most users.  If the buttons were tied to the screen orientation and simply flipped, this could be fixed quickly.
Agree, With the onslaught of convertibles on the market this will become a more frequent complaint. Flipping the button functions should be inherent nature in tablet mode.

Comment 6 by dymp...@gmail.com, Nov 9 2017

CBC-RS/TC-watchlist
Cc: yungleem@chromium.org
Components: OS>Kernel>Audio
Owner: alberto@chromium.org
@Alberto, can you take a look at this?
Cc: -drcrash@chromium.org tbuck...@chromium.org dgreid@chromium.org jennschen@chromium.org
+Tom and Jenn since this came up earlier

We're generally worried that changing the volume rocker behavior based on orientation would confuse users. The behavior of a particular volume button would vary based on orientation, without any clear indication to users that they are related.

Note that in convertible mode, there are two orientations (user facing camera on top, or on the bottom), resulting in more combinations which may cause confusion.

Also, on Android phones, the volume rocker behavior remains consistent across all orientations.
(but yes on Android phones you can't rotate the screen 180, I don't have a tablet with me at the moment)
#8 - I agree - buttons should maintain their function regardless of device orientation. Imagine the confusion as the user rotates the Chromebook between landscape and portrait mode, or some indeterminate angle in between.

If I push a button to raise the volume and the volume goes down instead, I simply press the other button. Simplicity.
On the Samsung Pro the power and volume are on the right side of the CB. 
The power button is at the top right side (hinges).

On the Asus Flip they are on the left side.
The power button is at the bottom (touchpad).

On both, volume up is towards the power button. 

Comment 12 by drcrash@google.com, Nov 11 2017

I simply press the other button. Simplicity.

Simplicity is having the button do the counterintuitive thing and the user
trying the alternative? That's news to me.
Confirmed that the behavior is the same on Android tablets (Pixel-C) too

Comment 14 by wpwoo...@gmail.com, Dec 31 2017

The iPad changes the volume button depending on screen orientation.  Its very intuitive.  Pressing the top volume button always raises the volume.  In portrait mode, the rightmost volume button should raise volume to match the user interface which goes left to right when raising volume.
Cc: dnojiri@chromium.org
I think volume buttons should be attached to the display panel. Then we should/can do:

https://www.androidpolice.com/2018/03/07/android-p-feature-spotlight-volume-slider-moves-side-screen-theres-superior-control-bluetooth-devices/

Comment 17 by igo@chromium.org, Apr 30 2018

Side note.

One thing we should be sure about: If we do this in the kernel and the change affects all devices (detachable, tablet, convertible), some of these devices rely on the volume rocker for EC/FW functions like recovery, etc. So if we say for tablets "hit volume up + [some other key]", need to make sure we are consistent and predictable.
Labels: Hotlist-ConOps-CrOS
(Bulk Edit) Adding the new conops Chrome OS hotlist to all open issues with the "#CBC-RS/TC-watchlist" tag, our former tracking tag.
Status: Assigned (was: Unconfirmed)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment