New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 750269 link

Starred by 1 user
Status: Fixed
Owner:
█ nyquist@chromium.org
Traveling - Back 2/6
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocked on:
issue 743275


Sign in to add a comment

[Component Request] FeatureEngagement [RENAME]

Project Member Reported by nyquist@chromium.org, Jul 28 2017 
Rename request.
Old component: Internals>FeatureEngagementTracker
New component: Internals>FeatureEngagement

1] Component Name: FeatureEngagement

2] Parent Component (e.g. Blink, UI>Browser, etc...):
Internals

3] Description of Component:
Feature Engagement is the In-Product Help (IPH) backend (storage, configuration, conditions, performance, etc.)

4] Admin/ Owner:
Same as before.

5] Please specify what triage practices will be followed for the component
(i.e. what team will do it and how frequently).

Same as before.

Comment 1 by nyquist@chromium.org, Jul 28 2017

Blockedon: 743275
The code for this has already been submitted as part of  issue 743275 .

Comment 2 by nyquist@chromium.org, Jul 28 2017 

The OWNERS-file will be updated in https://chromium-review.googlesource.com/c/592141/ as soon as the component name change has completed.

Comment 3 by lafo...@chromium.org, Aug 17 2017

Owner: nyquist@chromium.org
Status: Assigned (was: Untriaged)
Hey Tommy,

If the component doesn't need to be reparented, component admins can change the name w/ out a request.

https://bugs.chromium.org/p/chromium/components/detail?component=Internals%3EFeatureEngagementTracker

Comment 4 by nyquist@chromium.org, Aug 18 2017 

Thanks a ton! Component renamed all on my own :-)

CL to update source repository is in the CQ: https://chromium-review.googlesource.com/c/592141
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f19bd501b3059e9cca84b9a0690135e8f4259ac2

commit f19bd501b3059e9cca84b9a0690135e8f4259ac2
Author: Tommy Nyquist <nyquist@chromium.org>
Date: Fri Aug 18 17:55:40 2017

Rename crbug component for //components/feature_engagement.

The feature_engagement_tracker components was renamed to
feature_engagement as part of:
https://bugs.chromium.org/p/chromium/issues/detail?id=743275

This CL updates the crbug component name to match.

BUG= 750269 

Change-Id: I8e2672c98f6d5d578657926c042abac28b3a9814
Reviewed-on: https://chromium-review.googlesource.com/592141
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495610}
[modify] https://crrev.com/f19bd501b3059e9cca84b9a0690135e8f4259ac2/components/feature_engagement/OWNERS

Comment 6 by nyquist@chromium.org, Aug 18 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment