New issue
Advanced search Search tips

Issue 750262 link

Starred by 1 user
Status: Duplicate
Merged: issue 755581
Owner:
ryansturm@chromium.org
Closed: Sep 2017
Cc:
fgor...@chromium.org
dougarnett@chromium.org
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Disabling enable-offline-previews flag does not completely stop offline previews from being presented

Project Member Reported by dougarnett@chromium.org, Jul 28 2017 
On local build, I Disable the enable-offine-previews flag from chrome://flags and reload the browser (so that I can test other types of previews behavior). Unfortunately, I will still get Offline previews presented. So then I end up going to offline-internals page and deleting all offline pages to get them out of the way.

I can try to capture repro steps if needed.

Comment 1 by fgor...@chromium.org, Jul 28 2017

Cc: ryansturm@chromium.org
Hey, Doug,

Repro steps would definitely be helpful. I presume you are on a flaky network and not completely offline for this thing. Also I am not entirely sure this is a Offline pages problem. Ryan implemented previews IIRC.

/Filip

Comment 2 by ryansturm@chromium.org, Jul 28 2017 

This might be a bug in the flag itself on about:flags. If you set the Client-side is field trial to Disabled does that fix it?

Comment 3 by dougarnett@chromium.org, Jul 28 2017

Cc: -ryansturm@chromium.org dougarnett@chromium.org fgor...@chromium.org
Components: -UI>Browser>Offline UI>Browser>Previews
Owner: ryansturm@chromium.org

Comment 4 by dougarnett@chromium.org, Jul 28 2017 

Yeah, looks like || on being enabled here (happy to accept either flag or field trial): https://cs.chromium.org/chromium/src/components/previews/core/previews_experiments.cc?rcl=1746c9497c592b97b38baf217282364be1f8e9fd&l=149
so flag does not act as a kill switch (which is what I expected).

Comment 5 by dougarnett@chromium.org, Jul 28 2017 

From IM chat with Ryan, perhaps an appropriate fix is to have the field trial set the Feature and then just checking the Feature value (which may be set by either field trial or flag and then could kill disabled by flag).

Comment 6 by bengr@chromium.org, Aug 4 2017

Status: Assigned (was: Untriaged)
sgtm.

Comment 7 by ryansturm@chromium.org, Sep 8 2017

Mergedinto: 755581
Status: Duplicate (was: Assigned)
This should be fixed by 755581

Comment 8 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 9 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
►

Sign in to add a comment