New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 750252 link

Starred by 25 users
Status: Fixed
Owner:
enne@chromium.org
Closed: Aug 2017
Cc:
█ abdulsyed@chromium.org
pdr@chromium.org
gov...@chromium.org
█ hdodda@chromium.org
█ bustamante@chromium.org
pbomm...@chromium.org
Components:
EstimatedDays: ----
NextAction: 2017-08-11
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Vertical mask artifacts in flexible-height SVG during/after animation

Reported by tylersti...@gmail.com, Jul 28 2017 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.78 Safari/537.36

Steps to reproduce the problem:
1. Use a multi-element mask on another element within an SVG
2. Animate the mask via JavaScript (for example, using GSAP)
3. Scale the image using percentages

Occurs when SVG is directly in page: https://codepen.io/tylersticka/pen/d85119d8bae5876a94a7a6a5cb090a02/

Or when embedded via an object element, as on https://cloudfour.com

What is the expected behavior?
Element visibility should be limited to the visible portion of the mask even when values change or in a flexible container.

What went wrong?
Portions of the masked content escape the mask, resulting in visual artifacts.

Did this work before? Yes 59

Does this work in other browsers? Yes

Chrome version: 60.0.3112.78  Channel: stable
OS Version: OS X 10.12.6
Flash Version:
svg-mask-bug.gif
362 KB View Download

Comment 1 by tylersti...@gmail.com, Jul 28 2017 

Correction: It turns out the animating via JavaScript step is not necessary to reproduce. See attached use case, also visible in this pen: https://codepen.io/tylersticka/pen/1634b390adade3bb17213f715cfcc4b1?editors=1100
Screen Shot 2017-07-28 at 11.26.20 AM.png
67.5 KB View Download
index.html
9.0 KB View Download

Comment 2 by manoranj...@chromium.org, Jul 28 2017

Labels: Needs-Triage-M60 Needs-Bisect

Comment 3 by hernanto...@gmail.com, Jul 30 2017 

I'm adding a reduced example of apparently the same bug.
Mask fails when used in a group.
Works correctly if moved to the rect element.
https://codepen.io/airnan/pen/WErKPV

Comment 4 by hdodda@chromium.org, Jul 31 2017

Cc: hdodda@chromium.org
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision M-60 OS-Linux OS-Windows Pri-1
Owner: enne@chromium.org
Status: Assigned (was: Unconfirmed)
Tested the issue on windows 7 ,Mac os 10.12.5 and ubuntu 14.04 using chrome M60 #60.0.3112.78 and chrome canary M62 #62.0.3171.0 and issue is reproduced.

This is a regression issue broken in M60 .

Using the per-revision bisect providing the bisect results,
Good build: 60.0.3086.0(Revision: 468266).
Bad build: 60.0.3088.0 (Revision: 468845).

You are probably looking for a change made after 468547 (known good), but no later than 468548 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspectas some perf builds might get missing due to failure.

 https://chromium.googlesource.com/chromium/src/+log/4b3d57d3066c29135644cf93bd3b3e8092aeeed2..59df29deed59592d42ff7e600f33faf035e00b46

From the CL above, assigning the issue to the concern owner 

@enne- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2768143002

Thanks!

Comment 5 by schenney@chromium.org, Aug 1 2017

Components: -Blink>SVG Internals>Compositing
Labels: -Needs-Triage-M60 PaintTeamTriaged-20170801
This is a pretty serious regression issue. Paint Team guidelines give 30 days to fix this.

The issue is that tiles outside the mask are getting masked. That is, the incorrect painting lines up exactly with tile boundaries and scrolls with tiles.

Comment 6 by enne@chromium.org, Aug 1 2017

Cc: pdr@chromium.org
Sorry, I didn't update this after investigating lately.  The bisect appears to be correct.  It looks like SVGMaskPainter code is depending on assumptions about Skia saveLayerAlpha (in particular that the bounds provided are not a guarantee to be a clip, but often act as one).  I think the SVGMaskPainter just needs an extra clip when painting.

Comment 7 by manoranj...@chromium.org, Aug 1 2017

Cc: abdulsyed@chromium.org bustamante@chromium.org
Labels: ReleaseBlock-Stable
Marking it as 'RB-Stable' per c#5. Please feel free to edit if required.

Comment 9 by tylersti...@gmail.com, Aug 1 2017 

Note: We've updated https://cloudfour.com (provided in my original issue description as an example using an object element) with a quick-fix that disables the animation and any masks for Chrome ≥ 60, so it is no longer a good test case for this issue. (Just an FYI in case anyone reads the original issue and wonders why that particular example looks fine now.)

Comment 10 by manoranj...@chromium.org, Aug 3 2017 

schenney@/enne@, we are planning to ramp-up the stable update to 15% for Windows today. So just wondering, would it be OK waiting for next stable for this fix?  Please let us know your thoughts.

Thank you!

Comment 11 by schenney@chromium.org, Aug 3 2017

Labels: -M-60 M-61
Given the workaround (not great I know) we will not block M-60 stable on this. Adjusting to M-61 for RBS.

Given the time to fix, and the to and fro on the review, it's probably not a great stable merge candidate anyway.

Comment 12 by manoranj...@chromium.org, Aug 3 2017 

schenney@, thank you for the quick update!

*From c#10: Ramping-up the stable update to 15% for both "Windows & Mac" today!
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857

commit e3d9eee91f3dfe5503bde5f3f4fc776e1552f857
Author: Adrienne Walker <enne@chromium.org>
Date: Fri Aug 04 01:56:25 2017

Add explicit clip to compositing display items

SkCanvas::saveLayer(Alpha) which is indirectly generated by
CompositingDisplayItem takes an optional bounds as a hint for the size
of the backing that is used as an indirect offscreen texture for the
saveLayer.  This acts as an implicit clip, but Skia is free to make
this as large as possible or drop the clip.  PaintOpBuffer in particular
has some optimizations that sometimes drop the bounds when trying to
fold together saveLayer/draw/restore into a single draw with alpha.

This patch makes it so that any CompositingDisplayItem that provides
a clip has its content explicitly clipped.  This prevents optimizations
inside of PaintOpBuffer that would remove the save/restore generated
by the CompositingDisplayItem but prevents any accidental painting
outside of display item bounds.

Bug:  750252 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic651c35e1ce865f3008dd345952a6fbc97d94740
Reviewed-on: https://chromium-review.googlesource.com/596503
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491915}
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/cc/blink/BUILD.gn
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/cc/blink/web_display_item_list_impl.cc
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/cc/blink/web_display_item_list_impl.h
[add] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/cc/blink/web_display_item_list_impl_unittest.cc
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[delete] https://crrev.com/29eff3ab49027f70d179c783247568a3ffaacdac/third_party/WebKit/LayoutTests/animations/timing/animation-duration-infinite-expected.html
[add] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/animations/timing/animation-duration-infinite-expected.png
[add] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/animations/timing/animation-duration-infinite-expected.txt
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/fast/dynamic/anonymous-block-layer-lost-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/fast/layers/opacity-stacking-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/paint/invalidation/column-float-under-stacked-inline-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-inside-composited-intermediate-layer-expected.png
[delete] https://crrev.com/29eff3ab49027f70d179c783247568a3ffaacdac/third_party/WebKit/LayoutTests/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-bounce-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/compositing/sibling-positioning-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/fast/clip/nestedTransparencyClip-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/fast/css/ZeroOpacityLayers-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/fast/css/ZeroOpacityLayers2-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/fast/layers/remove-layer-with-nested-stacking-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/fast/multicol/composited-with-child-layer-in-next-column-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/fast/reflections/opacity-reflection-transform-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/fast/table/multiple-captions-display-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/fast/text/complex-text-opacity-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/absolute-sized-content-with-resources-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/use-detach-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textAnchor-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textFeatures-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textProperties-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/svg/custom/clip-mask-negative-scale-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/svg/custom/container-opacity-clip-viewBox-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/svg/custom/dominant-baseline-hanging-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/svg/custom/text-image-opacity-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-modify-container-in-target-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-modify-target-container-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-g-containing-use-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-g-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-use-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-transform-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/svg/transforms/text-with-mask-with-svg-transform-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-mask-with-percentages-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/transforms/transform-on-inline-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/transforms/transform-table-row-expected.png
[add] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/multiple-captions-display-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/complex-text-opacity-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/svg/use-detach-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/dominant-baseline-hanging-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac-mac10.10/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/complex-text-opacity-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/zoom/page/zoom-mask-with-percentages-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac-mac10.9/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/compositing/sibling-positioning-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/fast/css/ZeroOpacityLayers-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/fast/css/ZeroOpacityLayers2-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/fast/layers/remove-layer-with-nested-stacking-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/fast/reflections/opacity-reflection-transform-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/fast/table/multiple-captions-display-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/absolute-sized-content-with-resources-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/use-detach-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textAnchor-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textFeatures-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textProperties-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/svg/custom/clip-mask-negative-scale-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/svg/custom/container-opacity-clip-viewBox-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/svg/custom/dominant-baseline-hanging-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/svg/custom/text-image-opacity-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-modify-container-in-target-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-modify-target-container-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-g-containing-use-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-g-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-use-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-transform-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/transforms/transform-on-inline-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/transforms/transform-table-row-expected.png
[add] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/fast/table/multiple-captions-display-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/compositing/sibling-positioning-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/fast/css/ZeroOpacityLayers-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/fast/css/ZeroOpacityLayers2-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/fast/layers/remove-layer-with-nested-stacking-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/fast/reflections/opacity-reflection-transform-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/fast/table/multiple-captions-display-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/fast/text/complex-text-opacity-expected.png
[add] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/absolute-sized-content-with-resources-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/use-detach-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textAnchor-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textFeatures-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textProperties-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/svg/custom/clip-mask-negative-scale-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/svg/custom/container-opacity-clip-viewBox-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/svg/custom/dominant-baseline-hanging-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/svg/custom/text-image-opacity-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-modify-container-in-target-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-modify-target-container-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-on-g-containing-use-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-on-g-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-on-use-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-transform-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/svg/transforms/text-with-mask-with-svg-transform-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/transforms/transform-on-inline-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/transforms/transform-table-row-expected.png
[add] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/fast/table/multiple-captions-display-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win7/fast/text/complex-text-opacity-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/platform/win7/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/svg/custom/grayscale-gradient-mask-2-expected.png
[modify] https://crrev.com/e3d9eee91f3dfe5503bde5f3f4fc776e1552f857/third_party/WebKit/LayoutTests/svg/custom/grayscale-gradient-mask-e

Comment 14 by pbomm...@chromium.org, Aug 7 2017

Cc: pbomm...@chromium.org gov...@chromium.org
If the Cl looks good on Canary and safe to get merged to M61(Branch:3163), Please go ahead and request for the same.

Comment 15 by enne@chromium.org, Aug 8 2017 

How long do I have to merge this? I'm not particularly worried about it, but adding extra clips could expose preexisting incorrect visual rect bugs in corner cases.  I'd take another few days if there was time just to see if this flushed any bugs out.

Comment 16 by gov...@chromium.org, Aug 8 2017 

enne@, if merge happens by EOD Friday is fine. If you need little more time then, EOD Monday is also fine.

Comment 17 by enne@chromium.org, Aug 8 2017

NextAction: 2017-08-11

Comment 18 by gov...@chromium.org, Aug 9 2017 

[Bulk Edit]
URGENT - PTAL.
Your bug is labelled as M61 Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP.

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label.

Thank you.

Comment 19 by enne@chromium.org, Aug 10 2017

Labels: Merge-Request-61
I haven't seen any issues with this patch, so requesting merge to 61.
Project Member

Comment 20 by sheriffbot@chromium.org, Aug 10 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 21 by gov...@chromium.org, Aug 10 2017 

Thinking about this more, 
 - this patch is huge and M61 is already in Beta since August 4th.
 - issue exists on M60 Stable not M61 regression
 - There is a workaround and not a great stable merge candidate (per comment #11)

Can this wait until M62?

Also +abdulsyed@ (Chrome Desktop TPM) to take his input as well.

Comment 22 by enne@chromium.org, Aug 10 2017 

I think this patch is very small, to be honest.  There are many layout tests that change ever-so-slightly, but they're just layout test results.

The change without layout tests is this: https://chromium-review.googlesource.com/c/596503/8

This is the smallest change possible already, I think.  I think this is not risky and is worth landing in m61.  I think this bug is pretty bad.  This is the only report of it, but surely other folks are running into strange visual artifacts and haven't been kind enough to provide such an actionable repro case.

Comment 23 by sandeepkumars@chromium.org, Aug 11 2017

Labels: TE-Verified-M62 TE-Verified-62.0.3181.0
Tested the issue using #62.0.3181.0 on Mac 10.12.4, Win 10, Linux Ubuntu 14.04. Observed there are no artifacts seen on the page.

Please find the screen cast for the same. Hence adding verified labels.

Thanks!!
Aug 11 2017 11-34 AM.webm
1.8 MB View Download

Comment 24 by monor...@bugs.chromium.org, Aug 11 2017 

The NextAction date has arrived: 2017-08-11

Comment 25 by gov...@chromium.org, Aug 11 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 branch 3163 based on comment #19, #22 and #23 after discussing with abdulsyed@. Please merge ASAP. Thank you.
Project Member

Comment 26 by bugdroid1@chromium.org, Aug 11 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f18454c2bf68b6895308940b4ac2c9249921b9a

commit 9f18454c2bf68b6895308940b4ac2c9249921b9a
Author: Adrienne Walker <enne@chromium.org>
Date: Fri Aug 11 17:43:50 2017

Add explicit clip to compositing display items

SkCanvas::saveLayer(Alpha) which is indirectly generated by
CompositingDisplayItem takes an optional bounds as a hint for the size
of the backing that is used as an indirect offscreen texture for the
saveLayer.  This acts as an implicit clip, but Skia is free to make
this as large as possible or drop the clip.  PaintOpBuffer in particular
has some optimizations that sometimes drop the bounds when trying to
fold together saveLayer/draw/restore into a single draw with alpha.

This patch makes it so that any CompositingDisplayItem that provides
a clip has its content explicitly clipped.  This prevents optimizations
inside of PaintOpBuffer that would remove the save/restore generated
by the CompositingDisplayItem but prevents any accidental painting
outside of display item bounds.

TBR=enne@chromium.org

(cherry picked from commit e3d9eee91f3dfe5503bde5f3f4fc776e1552f857)

Bug:  750252 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic651c35e1ce865f3008dd345952a6fbc97d94740
Reviewed-on: https://chromium-review.googlesource.com/596503
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491915}
Reviewed-on: https://chromium-review.googlesource.com/612454
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#491}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/cc/blink/BUILD.gn
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/cc/blink/web_display_item_list_impl.cc
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/cc/blink/web_display_item_list_impl.h
[add] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/cc/blink/web_display_item_list_impl_unittest.cc
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[delete] https://crrev.com/0234225c87bd459b2039d642921e9a7ad502eb89/third_party/WebKit/LayoutTests/animations/timing/animation-duration-infinite-expected.html
[add] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/animations/timing/animation-duration-infinite-expected.png
[add] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/animations/timing/animation-duration-infinite-expected.txt
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/fast/dynamic/anonymous-block-layer-lost-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/fast/layers/opacity-stacking-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/paint/invalidation/column-float-under-stacked-inline-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-inside-composited-intermediate-layer-expected.png
[delete] https://crrev.com/0234225c87bd459b2039d642921e9a7ad502eb89/third_party/WebKit/LayoutTests/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-bounce-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/compositing/sibling-positioning-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/fast/clip/nestedTransparencyClip-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/fast/css/ZeroOpacityLayers-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/fast/css/ZeroOpacityLayers2-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/fast/layers/remove-layer-with-nested-stacking-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/fast/multicol/composited-with-child-layer-in-next-column-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/fast/reflections/opacity-reflection-transform-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/fast/table/multiple-captions-display-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/fast/text/complex-text-opacity-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/absolute-sized-content-with-resources-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/use-detach-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textAnchor-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textFeatures-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textProperties-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/svg/custom/clip-mask-negative-scale-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/svg/custom/container-opacity-clip-viewBox-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/svg/custom/dominant-baseline-hanging-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/svg/custom/text-image-opacity-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-modify-container-in-target-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-modify-target-container-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-g-containing-use-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-g-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-use-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-transform-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/svg/transforms/text-with-mask-with-svg-transform-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-mask-with-percentages-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/transforms/transform-on-inline-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/transforms/transform-table-row-expected.png
[add] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/multiple-captions-display-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/complex-text-opacity-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/svg/use-detach-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/dominant-baseline-hanging-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac-mac10.10/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/complex-text-opacity-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/zoom/page/zoom-mask-with-percentages-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/compositing/sibling-positioning-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/fast/css/ZeroOpacityLayers-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/fast/css/ZeroOpacityLayers2-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/fast/layers/remove-layer-with-nested-stacking-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/fast/reflections/opacity-reflection-transform-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/fast/table/multiple-captions-display-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/absolute-sized-content-with-resources-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/use-detach-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textAnchor-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textFeatures-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textProperties-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/svg/custom/clip-mask-negative-scale-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/svg/custom/container-opacity-clip-viewBox-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/svg/custom/dominant-baseline-hanging-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/svg/custom/text-image-opacity-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-modify-container-in-target-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-modify-target-container-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-g-containing-use-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-g-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-use-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-transform-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/transforms/transform-on-inline-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/transforms/transform-table-row-expected.png
[add] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/fast/table/multiple-captions-display-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/compositing/sibling-positioning-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/fast/css/ZeroOpacityLayers-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/fast/css/ZeroOpacityLayers2-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/fast/layers/remove-layer-with-nested-stacking-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/fast/reflections/opacity-reflection-transform-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/fast/table/multiple-captions-display-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/fast/text/complex-text-opacity-expected.png
[add] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/absolute-sized-content-with-resources-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/use-detach-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textAnchor-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textProperties-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/svg/custom/clip-mask-negative-scale-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/svg/custom/container-opacity-clip-viewBox-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/svg/custom/dominant-baseline-hanging-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/svg/custom/text-image-opacity-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-modify-container-in-target-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-modify-target-container-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-on-g-containing-use-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-on-g-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-on-use-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-transform-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/svg/transforms/text-with-mask-with-svg-transform-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/transforms/transform-on-inline-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/transforms/transform-table-row-expected.png
[add] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/fast/table/multiple-captions-display-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win7/fast/text/complex-text-opacity-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/platform/win7/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/svg/custom/grayscale-gradient-mask-2-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/svg/custom/grayscale-gradient-mask-expected.png
[modify] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/svg/custom/marker-opacity-expected.png
[add] https://crrev.com/9f18454c2bf68b6895308940b4ac2c9249921b9a/third_party/WebKit/LayoutTests/svg/custom/marker-zero-length-linecaps-expected.png
[delete] https://crrev.com/0234225c87bd459b2039d642921e9a7ad502eb89/third_party/

Comment 27 by enne@chromium.org, Aug 14 2017

Status: Fixed (was: Assigned)

Comment 28 by tylersti...@gmail.com, Sep 12 2017 

Unfortunately, I'm still seeing masks "leaking" single columns of vertical pixels while objects are rotated or transformed. It's much less noticeable than it was before, but it's definitely still there, at least on a high-resolution display MacBook Pro in Chrome version 61.0.3163.79. It does not occur in Firefox or Safari.

I slowed down the animation durations in my original issue's example to demonstrate: https://codepen.io/tylersticka/pen/d85119d8bae5876a94a7a6a5cb090a02/?editors=0010

I've also attached screenshots and a short screen recording where the issue is visible.
issue.mov
3.6 MB Download
Screen Shot 2017-09-12 at 10.30.02 AM.png
86.3 KB View Download
Screen Shot 2017-09-12 at 10.30.17 AM.png
168 KB View Download
►

Sign in to add a comment