LayoutTests/PRESUBMIT.py fails due to missing fast/text/atomic-inline-before-ellipsis.html |
||||
Issue descriptionThe new layout test was added here: https://chromium-review.googlesource.com/c/579973/ FlagExpectations were updated here: https://chromium-review.googlesource.com/c/590636/ Then the layout test was removed again: https://chromium-review.googlesource.com/c/591887 presubmit now fails with: ** Presubmit ERRORS ** third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG:10747 Path does not exist. fast/text/atomic-inline-before-ellipsis.html Lint failed.
,
Jul 28 2017
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50ca68ecd819b46a962734ba3dd9a3152c09c542 commit 50ca68ecd819b46a962734ba3dd9a3152c09c542 Author: Hans Wennborg <hans@chromium.org> Date: Fri Jul 28 17:40:24 2017 Remove atomic-inline-before-ellipsis.html from FlagExpectations/enable-blink-features=LayoutNG The layout test was removed in https://chromium-review.googlesource.com/c/591887 afterwhich presubmit checks started failing due to this file referring to a layout test that doesn't exist. BUG= 750248 TBR=eae Change-Id: I4e04a456b2dbe6cfabea2069da3c272c90b6c832 Reviewed-on: https://chromium-review.googlesource.com/591632 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#490448} [modify] https://crrev.com/50ca68ecd819b46a962734ba3dd9a3152c09c542/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
,
Jul 28 2017
Presubmit seems to be passing again: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/503025
,
Jul 28 2017
Thanks hans@!
,
Jul 29 2017
Thank you hans@! |
||||
►
Sign in to add a comment |
||||
Comment 1 by h...@chromium.org
, Jul 28 2017Status: Started (was: Assigned)