New issue
Advanced search Search tips

Issue 750244 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Render tests

Project Member Reported by rouslan@chromium.org, Jul 28 2017

Issue description

Would be good to have render tests for web payments UI to avoid regressions.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a86ac8934483c1fb835fa5804496bd0d60ec2f82

commit a86ac8934483c1fb835fa5804496bd0d60ec2f82
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Fri Aug 04 22:14:53 2017

[Payments] Render tests.

This patch adds render test for two web payments UI surfaces:

 - free_shipping: The bottom sheet for a website that provides free
   shipping.

 - unmask: The CVC unmask dialog.

Bug:  750244 
Change-Id: I26069bcad49d80ca5046436b9c38761a41154a6f
Reviewed-on: https://chromium-review.googlesource.com/591915
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492142}
[modify] https://crrev.com/a86ac8934483c1fb835fa5804496bd0d60ec2f82/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml
[modify] https://crrev.com/a86ac8934483c1fb835fa5804496bd0d60ec2f82/chrome/android/java/res/layout/payment_request.xml
[modify] https://crrev.com/a86ac8934483c1fb835fa5804496bd0d60ec2f82/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
[modify] https://crrev.com/a86ac8934483c1fb835fa5804496bd0d60ec2f82/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestCommon.java
[modify] https://crrev.com/a86ac8934483c1fb835fa5804496bd0d60ec2f82/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestRule.java
[add] https://crrev.com/a86ac8934483c1fb835fa5804496bd0d60ec2f82/components/test/data/payments/render_tests/PaymentRequestFreeShippingTest.free_shipping.Nexus_5-19.png
[add] https://crrev.com/a86ac8934483c1fb835fa5804496bd0d60ec2f82/components/test/data/payments/render_tests/PaymentRequestFreeShippingTest.unmask.Nexus_5-19.png
[add] https://crrev.com/a86ac8934483c1fb835fa5804496bd0d60ec2f82/components/test/data/payments/render_tests/README

Status: Fixed (was: Assigned)
Initial render tests have been setup.
Labels: -OS-Linux -OS-Windows -OS-iOS -OS-Chrome -OS-Mac

Sign in to add a comment