New issue
Advanced search Search tips

Issue 750191 link

Starred by 1 user
Status: Fixed
Owner:
weili@chromium.org
Closed: Sep 28
Cc:
sadrul@chromium.org
robliao@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 701833



Sign in to add a comment

Browser instance unable to inspect itself using UI DevTools on Win

Project Member Reported by tdander...@chromium.org, Jul 28 2017 
Observed on both:
* Win7 ToT build at revision #489647
* Win7 canary 62.0.3169.0

When visiting chrome://inspect#other on Chrome for Windows, you should be able to launch a UI DevTools front end within a new tab and use this to inspect the native UI of the same browser instance.


Steps to reproduce on a developer build:
1. Launch chrome with runtime flag --enable-ui-devtools=9332.
2. Navigate to chrome://inspect#other.
3. A link to the UI DevTools FE is shown, and the address lists the port 9332 passed on the command line. Click on this link.

What happens:
The UI DevTools FE opens, but only shows a "WebSocket disconnected" error.


Steps to reproduce on canary:
1. Launch chrome and navigate to chrome://inspect#other.

What happens:
No link is shown for UI DevTools.

Comment 1 by markchang@chromium.org, Sep 24

Cc: robliao@chromium.org
Owner: weili@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d83384e5de55125f77d475b3b58f578a306ca25d

commit d83384e5de55125f77d475b3b58f578a306ca25d
Author: Wei Li <weili@chromium.org>
Date: Fri Sep 28 16:47:58 2018

Fix ui_devtools client address

Our dev tools used '0.0.0.0' as client address which doesn't work
on Windows. See some silimar discussion at
https://github.com/senecajs/seneca-transport/issues/37. Since we
don't have any remote server discovery in place, it would be
sufficient to use local host address '127.0.0.1' for showing the
local client address on chrome://inspect page. Thus this CL fixes
the client address by replacing with local host address.

BUG= 750191 

Change-Id: Ife011e59316b472af3e56036d539282dd6667247
Reviewed-on: https://chromium-review.googlesource.com/1249271
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595121}
[modify] https://crrev.com/d83384e5de55125f77d475b3b58f578a306ca25d/components/ui_devtools/devtools_server.cc

Comment 3 by weili@chromium.org, Sep 28

Status: Fixed (was: Assigned)
►

Sign in to add a comment