Highlighter stroke should have rounded corners |
||||
Issue descriptionThe current implementation of the highlighter stroke (in ash::HighlighterView) is a 4x14dp rectangle being dragged around while keeping the vertical orientation. This looks nice most of the time, but sharp rectangular corners are often visible at both ends of the stroke. The corners should be rounded.
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc46d5f4397a8ba5e52393fb4227507e3032017c commit fc46d5f4397a8ba5e52393fb4227507e3032017c Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Thu Aug 03 00:58:24 2017 Add rounded corners to highlighter stroke Draw the outline of each segment with 4dp stroke and round joints. TBR=kaznacheev@google.com (cherry picked from commit b442dfacc61a91a2fc7ee48ab641c367f2b7b29f) Bug: 750171 Change-Id: I5db66e65ed4d526d890486c7b96c7379453b70b7 Reviewed-on: https://chromium-review.googlesource.com/591610 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#490838} Reviewed-on: https://chromium-review.googlesource.com/599153 Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#259} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/fc46d5f4397a8ba5e52393fb4227507e3032017c/ash/highlighter/highlighter_view.cc
,
Aug 3 2017
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Aug 1 2017