New issue
Advanced search Search tips

Issue 750144 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Distinguish Gerrit reviewers with <username>+reviewer@chromium.org

Project Member Reported by rdsmith@chromium.org, Jul 28 2017

Issue description

Rietveld automatically sent emails to reviewers with a "+reviewer" suffixed to the username. Gerrit appears not to do this--it sends emails to just <username>@chromium.org.  This borks my mail filters and worse, I can't figure out any way to fix them--gmail appears to consider -rdsmith@chromium.org as applying to both rdsmith+watch@ & rdsmith+cc@, so I can't send things on my watchlist that I haven't been asked to review to a separate folder.

(My apologies for the high priority, and you're welcome to set it down on the basis that this is just one developer, but it's very likely I'm going to have to mass remove myself from watchlists unless I can find some way to do this filtering properly.)

 

Comment 1 by aga...@chromium.org, Jul 28 2017

Owner: aga...@chromium.org
Status: WontFix (was: Untriaged)
Yes, Gerrit purposefully does not add "+reviewer" (or "+owner" or "+cc") to the email addresses that it uses in emails, and it will not start doing so for backwards compatibility reasons with the other external groups who have been using Gerrit for years.

Please update your filters to use Gerrit's extensive email metadata instead of just the to: address: https://gerrit-review.googlesource.com/Documentation/user-notify.html#footers
Ah, thank you!!  That looks like it'll solve my problem.

Sign in to add a comment