[Sync] EntryResponse field inconsistently named in sync.proto |
||
Issue description"EntryResponse" in sync.proto has an inlined definition and usage. While it's name conforms to typical message naming pattern, the field name ens up being "entryresponse" when it should be "entry_response". We should be able to fix this without breaking any compatability.
,
Jul 28 2017
See https://cs.chromium.org/chromium/src/components/sync/protocol/sync.proto?q=EntryResponse&sq=package:chromium&dr=CSs&l=844 > repeated group EntryResponse = 1 {
,
Aug 2 2017
Group name is used for both class name and field name generation. It must start with capital letter. We can rename EntryResponse to Entry_Response which will change field name to entry_response, but that will change type name to Entry_Response which is used in multiple places (commit_util.h for example). We cannot switch from group to message without affecting wire format. Resolving as won't fix as fixing it introduces different naming issue. |
||
►
Sign in to add a comment |
||
Comment 1 by s...@chromium.org
, Jul 28 2017