New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 750133 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Aug 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

ContentSuggestions are shown in Most Visited tiles

Project Member Reported by gambard@chromium.org, Jul 28 2017 
The ContentSuggestions are opened with a transition type AUTO_BOOKMARK. In order to prevent them from surfacing on the Most Visited tiles, the consider_for_ntp_most_visited boolean (in HistoryAddPageArgs) should be set to false.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef218ea8e37668001679f1170fb01ce54711833f

commit ef218ea8e37668001679f1170fb01ce54711833f
Author: gambard <gambard@chromium.org>
Date: Tue Aug 01 17:01:43 2017

Remove Suggestions opening from Most Visited count

When the user open a suggestion, it has a transition of type
PAGE_TRANSITION_AUTO_BOOKMARK. Those transitions have a large weight
when the Most Visited URL are computed.
In order to avoid to have the suggestions being too present in the
Most Visited tiles, they should not be considered when computing the
Most Visited URL.

Bug:  750133 
Change-Id: Ie54191b8e8d41ee787bf648a4d37044b11c690ff
Reviewed-on: https://chromium-review.googlesource.com/593320
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491021}
[modify] https://crrev.com/ef218ea8e37668001679f1170fb01ce54711833f/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/ef218ea8e37668001679f1170fb01ce54711833f/ios/chrome/browser/tabs/tab.mm

Comment 2 by mvanouwe...@chromium.org, Aug 2 2017

Labels: zine-triaged

Comment 3 by gambard@chromium.org, Aug 3 2017

Status: Fixed (was: Assigned)

Comment 4 by rakurati@chromium.org, Aug 8 2017

Status: Verified (was: Fixed)
Verified on latest canary 62.0.3179.0 in iPhone7(iOS 10.3.3) with the below steps

Tested as per comment #1, loading the URL's from content suggestions will not be surface/display in the most visited tiles. Looks good.
►

Sign in to add a comment