validation errors are not displayed |
||||
Issue descriptionQuite often users go to luci-config.appspot.com to see what's up with their commit, was it accepted or not. If the latest import attempt failed, there may be validation errors and that is the most valuable piece of info for them. Please display validation errors if any. They are returned by the get_config_set API.
,
Jul 29 2017
,
Jul 31 2017
This sounds like the error message is not immediately obvious to discover. Perhaps, it could be included in the text bubble for the icon? Or the bubble would say "click for more info", and on the config set page the icon is displayed next to the error text, so they are visually related?
,
Jul 31 2017
Maybe instead of displaying icon next to error text it would be better to make the error message red to visually connect it with icon?
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/e5c03a06ae1e8585f4944d2b57ab156ed5b5f071 commit e5c03a06ae1e8585f4944d2b57ab156ed5b5f071 Author: ayanaadylova <ayanaadylova@google.com> Date: Tue Aug 01 21:24:05 2017 config_service: make validation errors more distinguishable BUG= 749999 Review-Url: https://codereview.chromium.org/2988223002 [modify] https://crrev.com/e5c03a06ae1e8585f4944d2b57ab156ed5b5f071/appengine/config_service/ui/src/config-ui/config-set-card.html [modify] https://crrev.com/e5c03a06ae1e8585f4944d2b57ab156ed5b5f071/appengine/config_service/ui/src/config-ui/config-set.html
,
Aug 3 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ayanaadylova@google.com
, Jul 28 2017